Skip to content

[Bugfix] Fix f-string formatting in image generation pipelines #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
david6666666 merged 1 commit into from
Jan 7, 2026
Merged

[Bugfix] Fix f-string formatting in image generation pipelines #689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vllm_omni/diffusion/models/longcat_image/pipeline_longcat_image_edit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,7 +466,7 @@ def check_inputs(
if height % (self.vae_scale_factor * 2) != 0 or width % (self.vae_scale_factor * 2) != 0:
logger.warning(
"`height` and `width` have to be divisible by "
"{self.vae_scale_factor * 2} but are {height} and {width}. "
f"{self.vae_scale_factor * 2} but are {height} and {width}. "
"Dimensions will be resized accordingly"
)

Expand Down
2 changes: 1 addition & 1 deletion vllm_omni/diffusion/models/ovis_image/pipeline_ovis_image.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ def check_inputs(
"Provide either `prompt` or `prompt_embeds`. Cannot leave both `prompt` and `prompt_embeds` undefined."
)
elif prompt is not None and (not isinstance(prompt, str) and not isinstance(prompt, list)):
raise ValueError("`prompt` has to be of type `str` or `list[str]` but is {type(prompt)}")
raise ValueError(f"`prompt` has to be of type `str` or `list[str]` but is {type(prompt)}")

if negative_prompt is not None and negative_prompt_embeds is not None:
raise ValueError(
Expand Down
2 changes: 1 addition & 1 deletion vllm_omni/diffusion/models/qwen_image/pipeline_qwen_image.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ def check_inputs(
if height % (self.vae_scale_factor * 2) != 0 or width % (self.vae_scale_factor * 2) != 0:
logger.warning(
f"`height` and `width` have to be divisible by {self.vae_scale_factor * 2} "
"but are {height} and {width}. Dimensions will be resized accordingly"
f"but are {height} and {width}. Dimensions will be resized accordingly"
)

# if callback_on_step_end_tensor_inputs is not None and not all(
Expand Down