[BugFix] token2wav code out of range#655
Merged
Gaohan123 merged 1 commit intovllm-project:mainfrom Jan 6, 2026
Merged
Conversation
Signed-off-by: dengyunyang <[email protected]>
Collaborator
|
@tzhouam @Gaohan123 is the range diffference a known problem? |
Collaborator
|
for qwen3-omni, does this happen? |
Contributor
Author
Qwen3-omni may not have this problem: code2wav_config.codebook_size = 2048 It same. |
Shirley125
pushed a commit
to Shirley125/vllm-omni
that referenced
this pull request
Jan 9, 2026
Signed-off-by: dengyunyang <[email protected]>
princepride
pushed a commit
to princepride/vllm-omni
that referenced
this pull request
Jan 10, 2026
Signed-off-by: dengyunyang <[email protected]>
sniper35
pushed a commit
to sniper35/vllm-omni
that referenced
this pull request
Jan 10, 2026
Signed-off-by: dengyunyang <[email protected]>
ZJY0516
pushed a commit
to LawJarp-A/vllm-omni
that referenced
this pull request
Jan 10, 2026
Signed-off-by: dengyunyang <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.
Purpose
As show in #476
Talker with vocab_size 8448, while token2wav with 8193, and it will result out of range in token2wav.
Modify:
we suppress the token id [8194:8448] in talker stage.
Test Plan
Run the benchmark again!
Test Result
All Request Success
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)