Skip to content

Comments

[Feature] Support Omni serving abort request#486

Merged
hsliuustc0106 merged 25 commits intovllm-project:mainfrom
ZeldaHuang:support_abort
Dec 31, 2025
Merged

[Feature] Support Omni serving abort request#486
hsliuustc0106 merged 25 commits intovllm-project:mainfrom
ZeldaHuang:support_abort

Conversation

@ZeldaHuang
Copy link
Contributor

PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.

Purpose

ref #419
Changes:

  • Add OmniStageTaskType indicate the different task send to stage's in_q, for now there are three task types : SHUTDOWN、GENERATE、ABORT
  • Add abort interface to AsyncOmni. If the user cancels generation on the client side, we will catch the GeneratorExit error and submit an abort task to all stages.

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft.

BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)

Signed-off-by: ZeldaHuang <hzm414167@alibaba-inc.com>
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Signed-off-by: ZeldaHuang <hzm414167@alibaba-inc.com>
@hsliuustc0106
Copy link
Collaborator

please resolve conflicts after #391 merged

Signed-off-by: ZeldaHuang <hzm414167@alibaba-inc.com>
Signed-off-by: ZeldaHuang <hzm414167@alibaba-inc.com>
Signed-off-by: ZeldaHuang <hzm414167@alibaba-inc.com>
Signed-off-by: ZeldaHuang <hzm414167@alibaba-inc.com>
Signed-off-by: ZeldaHuang <hzm414167@alibaba-inc.com>
@ZeldaHuang
Copy link
Contributor Author

please resolve conflicts after #391 merged

@hsliuustc0106 Done

@hsliuustc0106 hsliuustc0106 added the ready label to trigger buildkite CI label Dec 29, 2025
@hsliuustc0106
Copy link
Collaborator

fix ci please

@hsliuustc0106
Copy link
Collaborator

@yinpeiqi PTAL

@yinpeiqi
Copy link
Contributor

lgtm. Do we need test case for abort operation?

@hsliuustc0106
Copy link
Collaborator

hsliuustc0106 commented Dec 29, 2025

Signed-off-by: ZeldaHuang <hzm414167@alibaba-inc.com>
Signed-off-by: ZeldaHuang <hzm414167@alibaba-inc.com>
Signed-off-by: ZeldaHuang <hzm414167@alibaba-inc.com>
@ZeldaHuang
Copy link
Contributor Author

@hsliuustc0106 add test_async_omni.py , please review

@hsliuustc0106
Copy link
Collaborator

@yinpeiqi PTAL for the asyncomni

ZeldaHuang and others added 2 commits December 30, 2025 19:55
Signed-off-by: ZeldaHuang <hzm414167@alibaba-inc.com>
@hsliuustc0106
Copy link
Collaborator

[2025-12-30T12:14:22Z] WARNING 12-30 12:14:22 [omni.py:292] [AsyncOrchestrator] Initialization timeout: only 0/1 stages are ready; not ready: [0].

it seems the timeout problem, how long do you wait for the engine initializaiton

for the current online case:

        # Wait for server to be ready
        max_wait = 600  # 10 minutes
        start_time = time.time()
        while time.time() - start_time < max_wait:
            try:
                with socket.socket(socket.AF_INET, socket.SOCK_STREAM) as sock:
                    sock.settimeout(1)
                    result = sock.connect_ex((self.host, self.port))
                    if result == 0:
                        print(f"Server ready on {self.host}:{self.port}")
                        return
            except Exception:
                pass
            time.sleep(2)

        raise RuntimeError(f"Server failed to start within {max_wait} seconds")

Signed-off-by: ZeldaHuang <hzm414167@alibaba-inc.com>
Signed-off-by: ZeldaHuang <hzm414167@alibaba-inc.com>
Signed-off-by: ZeldaHuang <hzm414167@alibaba-inc.com>
@ZeldaHuang
Copy link
Contributor Author

@hsliuustc0106 It seems that simple unit test only has cpu environment, move asyn_comni test to e2e test

@hsliuustc0106
Copy link
Collaborator

@hsliuustc0106 It seems that simple unit test only has cpu environment, move asyn_comni test to e2e test

ORZ, I just realized it.

Signed-off-by: ZeldaHuang <hzm414167@alibaba-inc.com>
Signed-off-by: ZeldaHuang <hzm414167@alibaba-inc.com>
Signed-off-by: ZeldaHuang <hzm414167@alibaba-inc.com>
Signed-off-by: ZeldaHuang <hzm414167@alibaba-inc.com>
Signed-off-by: ZeldaHuang <hzm414167@alibaba-inc.com>
@hsliuustc0106 hsliuustc0106 merged commit ad0224f into vllm-project:main Dec 31, 2025
7 checks passed
@amy-why-3459 amy-why-3459 mentioned this pull request Dec 31, 2025
31 tasks
princepride pushed a commit to princepride/vllm-omni that referenced this pull request Jan 10, 2026
Signed-off-by: ZeldaHuang <hzm414167@alibaba-inc.com>
Signed-off-by: Hongsheng Liu <liuhongsheng4@huawei.com>
Co-authored-by: Hongsheng Liu <liuhongsheng4@huawei.com>
ZJY0516 pushed a commit to LawJarp-A/vllm-omni that referenced this pull request Jan 10, 2026
Signed-off-by: ZeldaHuang <hzm414167@alibaba-inc.com>
Signed-off-by: Hongsheng Liu <liuhongsheng4@huawei.com>
Co-authored-by: Hongsheng Liu <liuhongsheng4@huawei.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready label to trigger buildkite CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants