[Model] Add Stable Audio Open support for text-to-audio generation#331
Conversation
Signed-off-by: linyueqian <[email protected]>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| num_inference_steps = req.num_inference_steps or num_inference_steps | ||
| guidance_scale = req.guidance_scale if req.guidance_scale > 1.0 else guidance_scale | ||
|
|
There was a problem hiding this comment.
Honor guidance_scale ≤1 from requests
guidance_scale from the request is only applied when it exceeds 1.0; otherwise the pipeline falls back to the default argument (7.0). This prevents callers from disabling classifier-free guidance or using a lower scale (e.g., requesting 0 or 1 via Omni.generate), because the model will always run CFG at scale 7 regardless of what was requested, making unconditional/low-guidance Stable Audio generation impossible.
Useful? React with 👍 / 👎.
|
add test ci |
Signed-off-by: linyueqian <[email protected]>
Signed-off-by: linyueqian <[email protected]>
@hsliuustc0106 For online serving of Stable Audio, is a simple FastAPI wrapper around OmniDiffusion the right approach, or is there existing/planned infrastructure I should use? |
Signed-off-by: Yueqian Lin <[email protected]>
@david6666666 I notice you are working on the video online serving, is it possible to support audio output as well? #437 |
I think we need to open another PR to enable online audio serving, after this text-to-audio model is supported. |
Signed-off-by: Yueqian Lin <[email protected]>
Signed-off-by: linyueqian <[email protected]>
Signed-off-by: linyueqian <[email protected]>
hsliuustc0106
left a comment
There was a problem hiding this comment.
add supported models
Signed-off-by: linyueqian <[email protected]>
|
@hsliuustc0106 is this pr ready to be merged now? |
|
fix ci please |
|
@Bounty-hunter PTAL |
|
fix ci please |
Signed-off-by: linyueqian <[email protected]>
Signed-off-by: linyueqian <[email protected]>
Head branch was pushed to by a user without write access
|
@ZJY0516 I checked my code, and it doesn't seem to be my problem. I only added a special case check to determine whether it's a diffusion model in the end of vllm-omni/vllm_omni/diffusion/utils/hf_utils.py Lines 77 to 79 in ad3011d But I noticed that the model stabilityai/stable-audio-open-1.0 used for testing isn't a directly accessible model, an application is required.
|
Thanks. I found this too. This works fine on my local machine. |
|
I noticed some warnings. Could you please solve this? @linyueqian |
Signed-off-by: linyueqian <[email protected]>
I've fixed the first warning (T5Tokenizer legacy) by switching to T5TokenizerFast in this commit. And I think the remaining warnings are from third-party dependencies that cannot be fixed here. |
Signed-off-by: linyueqian <[email protected]>
Signed-off-by: linyueqian <[email protected]>
|
@hsliuustc0106 i think the ci issue is fixed here. |
thanks for contributing the first text-2-audio model |
|
please remember to submit a PR to vllm-project/recipe |
…llm-project#331) Signed-off-by: linyueqian <[email protected]> Signed-off-by: Yueqian Lin <[email protected]> Co-authored-by: Hongsheng Liu <[email protected]>
|
…llm-project#331) Signed-off-by: linyueqian <[email protected]> Signed-off-by: Yueqian Lin <[email protected]> Co-authored-by: Hongsheng Liu <[email protected]>
…llm-project#331) Signed-off-by: linyueqian <[email protected]> Signed-off-by: Yueqian Lin <[email protected]> Co-authored-by: Hongsheng Liu <[email protected]>
…llm-project#331) Signed-off-by: linyueqian <[email protected]> Signed-off-by: Yueqian Lin <[email protected]> Co-authored-by: Hongsheng Liu <[email protected]>
PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.
Purpose
Add support for Stable Audio Open (stabilityai/stable-audio-open-1.0) for text-to-audio generation in vLLM-Omni.
Test Plan
python examples/offline_inference/text_to_audio/text_to_audio.py --model stabilityai/stable-audio-open-1.0 --prompt "The sound of a dog barking" --output dog_barking.wavTest Result
dog_barking.wav
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)