Skip to content

[bugfix] Fix QwenImageEditPipeline transformer init#245

Merged
SamitHuang merged 1 commit intovllm-project:mainfrom
dougbtv:fix-od-config-qwen-image-edit
Dec 9, 2025
Merged

[bugfix] Fix QwenImageEditPipeline transformer init#245
SamitHuang merged 1 commit intovllm-project:mainfrom
dougbtv:fix-od-config-qwen-image-edit

Conversation

@dougbtv
Copy link
Contributor

@dougbtv dougbtv commented Dec 8, 2025

Basic gist is that when I went to use the QwenImageEditPipeline, I was getting an error like:

TypeError: QwenImageTransformer2DModel.__init__() missing 1 required positional argument: 'od_config'
[rank0]:[W1208 11:42:45.848416931 ProcessGroupNCCL.cpp:1538] Warning: WARNING: destroy_process_group() was not called before program exit, which can leak resources. For more info, please see https://pytorch.org/docs/stable/distributed.html#shutdown (function operator())

So I put together this patch. Thanks!


The QwenImageTransformer2DModel requires od_config as a positional argument, but the QwenImageEditPipeline was initializing it without passing this parameter, causing a TypeError at runtime.

This commit updates the initialization to match the pattern used in QwenImagePipeline (line 270 of pipeline_qwen_image.py):

self.transformer = QwenImageTransformer2DModel(od_config=od_config)

Error before fix:
TypeError: QwenImageTransformer2DModel.init() missing 1 required
positional argument: 'od_config'

PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.

The QwenImageTransformer2DModel requires od_config as a positional
argument, but the QwenImageEditPipeline was initializing it without
passing this parameter, causing a TypeError at runtime.

This commit updates the initialization to match the pattern used in
QwenImagePipeline (line 270 of pipeline_qwen_image.py):

    self.transformer = QwenImageTransformer2DModel(od_config=od_config)

Error before fix:
    TypeError: QwenImageTransformer2DModel.__init__() missing 1 required
    positional argument: 'od_config'

Signed-off-by: dougbtv <[email protected]>
Copy link
Collaborator

@SamitHuang SamitHuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. this argument was introduced to dit transformers in #219

@SamitHuang SamitHuang merged commit 811b5f9 into vllm-project:main Dec 9, 2025
4 checks passed
@ZJY0516
Copy link
Collaborator

ZJY0516 commented Dec 9, 2025

It sems that we need more CI test

LawJarp-A pushed a commit to LawJarp-A/vllm-omni that referenced this pull request Dec 12, 2025
LawJarp-A pushed a commit to LawJarp-A/vllm-omni that referenced this pull request Dec 12, 2025
faaany pushed a commit to faaany/vllm-omni that referenced this pull request Dec 19, 2025
princepride pushed a commit to princepride/vllm-omni that referenced this pull request Jan 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants