Skip to content

Fix Qwen3-TTS gradio demo - #2372

Merged
princepride merged 1 commit into
vllm-project:mainfrom
EmbeddedLLM:fix-qwen3-tts-demo
Mar 31, 2026
Merged

Fix Qwen3-TTS gradio demo#2372
princepride merged 1 commit into
vllm-project:mainfrom
EmbeddedLLM:fix-qwen3-tts-demo

Conversation

@noobHappylife

Copy link
Copy Markdown
Contributor

Purpose

The Qwen3-TTS is not working as-is now. 2 issues:

  • page-init JS path doesn't seem to be registered properly, so window.ttsGenerate was never registered and the browser never sent the speech request.
  • for CustomVoice task, it's using "speaker" param field, which has no impact.

Fixed the page-init JS path so it registered properly, and change the "speaker" param field to "voice"

Test Plan

Test Result

Tested it locally and the CustomVoice demo is working with different speaker.


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan. Please provide the test scripts & test commands. Please state the reasons if your codes don't require additional test scripts. For test file guidelines, please check the test style doc
  • The test results. Please paste the results comparison before and after, or the e2e results.
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model. Please run mkdocs serve to sync the documentation editions to ./docs.
  • (Optional) Release notes update. If your change is user-facing, please update the release notes draft.

BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)

Signed-off-by: noobhappylife <aratar1991@hotmail.com>

@princepride princepride left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@princepride
princepride enabled auto-merge (squash) March 31, 2026 11:20
@princepride princepride added the ready label to trigger buildkite CI label Mar 31, 2026
@princepride
princepride merged commit 7cb7b3e into vllm-project:main Mar 31, 2026
5 of 6 checks passed
vraiti pushed a commit to vraiti/vllm-omni that referenced this pull request Apr 9, 2026
Signed-off-by: noobhappylife <aratar1991@hotmail.com>
lengrongfu pushed a commit to lengrongfu/vllm-omni that referenced this pull request May 1, 2026
Signed-off-by: noobhappylife <aratar1991@hotmail.com>
clodaghwalsh17 pushed a commit to clodaghwalsh17/nm-vllm-omni-ent that referenced this pull request May 12, 2026
Signed-off-by: noobhappylife <aratar1991@hotmail.com>
daixinning pushed a commit to daixinning/vllm-omni that referenced this pull request May 28, 2026
Signed-off-by: noobhappylife <aratar1991@hotmail.com>
quyifei23 pushed a commit to quyifei23/vllm-omni that referenced this pull request Jun 6, 2026
Signed-off-by: noobhappylife <aratar1991@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready label to trigger buildkite CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants