Fix: Safe handling for multimodal_config to avoid 'NoneType' object h…#227
Merged
hsliuustc0106 merged 1 commit intovllm-project:mainfrom Dec 7, 2025
Merged
Fix: Safe handling for multimodal_config to avoid 'NoneType' object h…#227hsliuustc0106 merged 1 commit intovllm-project:mainfrom
hsliuustc0106 merged 1 commit intovllm-project:mainfrom
Conversation
…as no attribute '__dict__' error Fix: Safe handling for multimodal_config to avoid 'NoneType' object has no attribute '__dict__' error Signed-off-by: Baoyuan Qi <[email protected]>
LawJarp-A
pushed a commit
to LawJarp-A/vllm-omni
that referenced
this pull request
Dec 12, 2025
vllm-project#227) Signed-off-by: Baoyuan Qi <[email protected]> Signed-off-by: Prajwal A <[email protected]>
LawJarp-A
pushed a commit
to LawJarp-A/vllm-omni
that referenced
this pull request
Dec 12, 2025
vllm-project#227) Signed-off-by: Baoyuan Qi <[email protected]> Signed-off-by: Prajwal A <[email protected]>
faaany
pushed a commit
to faaany/vllm-omni
that referenced
this pull request
Dec 19, 2025
vllm-project#227) Signed-off-by: Baoyuan Qi <[email protected]> Signed-off-by: Fanli Lin <[email protected]>
princepride
pushed a commit
to princepride/vllm-omni
that referenced
this pull request
Jan 10, 2026
vllm-project#227) Signed-off-by: Baoyuan Qi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.
Purpose
This PR fixes an issue where multimodal_config may be None, causing:
AttributeError: 'NoneType' object has no attribute '__dict__'The original implementation assumes that multimodal_config is always an object with a dict attribute, but in real configurations it may be:
None
A dict
An object with attributes
This PR adds a safe, concise one-line implementation that supports all cases without changing existing behavior.
Test Plan
Initialize Omni model with:
Test Result
All cases load successfully.
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)