Skip to content

Comments

[CI] Add Qwen3-omni offline UT#216

Merged
Gaohan123 merged 2 commits intovllm-project:mainfrom
R2-Y:qwen3_offline_test
Dec 8, 2025
Merged

[CI] Add Qwen3-omni offline UT#216
Gaohan123 merged 2 commits intovllm-project:mainfrom
R2-Y:qwen3_offline_test

Conversation

@R2-Y
Copy link
Contributor

@R2-Y R2-Y commented Dec 5, 2025

PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.

Purpose

Add offline UT for qwen3-omni

Test Plan

pytest -sv tests/multi_stages/test_qwen3_omni.py

Test Result

Pass

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft.

BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)

@R2-Y R2-Y requested a review from hsliuustc0106 as a code owner December 5, 2025 10:15
@chatgpt-codex-connector
Copy link

The account who enabled Codex for this repo no longer has access to Codex. Please contact the admins of this repo to enable Codex again.

@R2-Y
Copy link
Contributor Author

R2-Y commented Dec 5, 2025

@ywang96 Hi Roger, I’m running pytest on an H200 with a tweaked qwen3‑omni config. I’m worried it may not work on A100 or other GPUs. Could you let me know which device types are available on Buildkite? So I can update the CI yaml to test again. Thanks!

@gcanlin
Copy link
Contributor

gcanlin commented Dec 5, 2025

Maybe we could reuse the conftest.py in #168.

@R2-Y
Copy link
Contributor Author

R2-Y commented Dec 6, 2025

Maybe we could reuse the conftest.py in #168.

Sure, I refer your PR, can add one single modality test to conftest.py later after your's merged.

@ywang96
Copy link
Member

ywang96 commented Dec 6, 2025

Maybe it's a good idea to use 2xH100 for qwen3-omni e2e test for now unless we run into resource issues. Feel free to take a look at #221

@R2-Y R2-Y force-pushed the qwen3_offline_test branch from 9e832ab to 2f6b25d Compare December 8, 2025 02:15
@R2-Y R2-Y changed the title Add Qwen3-omni offline UT [CI] Add Qwen3-omni offline UT Dec 8, 2025
@R2-Y R2-Y force-pushed the qwen3_offline_test branch 3 times, most recently from c095e40 to 9de9934 Compare December 8, 2025 06:16
Signed-off-by: Rein Yang <ruiruyang2@gmail.com>
@R2-Y R2-Y force-pushed the qwen3_offline_test branch from 9de9934 to 7cc0f60 Compare December 8, 2025 06:29
@R2-Y
Copy link
Contributor Author

R2-Y commented Dec 8, 2025

Maybe it's a good idea to use 2xH100 for qwen3-omni e2e test for now unless we run into resource issues. Feel free to take a look at #221

Thanks your suggestion, CI passed

Signed-off-by: Rein Yang <ruiruyang2@gmail.com>
@R2-Y R2-Y force-pushed the qwen3_offline_test branch from 5d06a21 to 3d53aa3 Compare December 8, 2025 08:32
Copy link
Collaborator

@Gaohan123 Gaohan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Gaohan123 Gaohan123 merged commit baf1086 into vllm-project:main Dec 8, 2025
4 checks passed
@hsliuustc0106
Copy link
Collaborator

please check with other test PRs and make all of them aligned with each other including the naming, test cases and util functions

LawJarp-A pushed a commit to LawJarp-A/vllm-omni that referenced this pull request Dec 12, 2025
Signed-off-by: Rein Yang <ruiruyang2@gmail.com>
Signed-off-by: Prajwal A <prajwalanagani@gmail.com>
LawJarp-A pushed a commit to LawJarp-A/vllm-omni that referenced this pull request Dec 12, 2025
Signed-off-by: Rein Yang <ruiruyang2@gmail.com>
Signed-off-by: Prajwal A <prajwalanagani@gmail.com>
faaany pushed a commit to faaany/vllm-omni that referenced this pull request Dec 19, 2025
Signed-off-by: Rein Yang <ruiruyang2@gmail.com>
Signed-off-by: Fanli Lin <fanli.lin@intel.com>
@R2-Y R2-Y deleted the qwen3_offline_test branch January 6, 2026 15:28
princepride pushed a commit to princepride/vllm-omni that referenced this pull request Jan 10, 2026
Signed-off-by: Rein Yang <ruiruyang2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants