Conversation
Signed-off-by: Roger Wang <[email protected]>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
pyproject.toml
Outdated
| license = "Apache-2.0" | ||
| license-files = ["LICENSE"] |
There was a problem hiding this comment.
license-files was added inside the [project] table (pyproject.toml lines 11-12), but PEP 621 only permits the standard keys there; setuptools’ PEP 621 validator rejects unknown fields, so python -m build/pip install . will error with an “additional properties are not allowed (‘license-files’)” message before producing a wheel. Move license-files under [tool.setuptools] (or drop it) to restore builds.
Useful? React with 👍 / 👎.
Signed-off-by: Roger Wang <[email protected]>
Signed-off-by: Roger Wang <[email protected]>
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Signed-off-by: Roger Wang <[email protected]> Signed-off-by: Prajwal A <[email protected]>
Signed-off-by: Roger Wang <[email protected]>
2 participants
PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.
Purpose
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)