[Bugfix][Qwen3-TTS] Preserve original model ID in omni_snapshot_download#1318
Merged
Gaohan123 merged 2 commits intovllm-project:mainfrom Feb 11, 2026
Merged
Conversation
Signed-off-by: linyueqian <linyueqian@outlook.com>
a75bcd8 to
b32eb35
Compare
YanickSchraner
pushed a commit
to YanickSchraner/vllm-omni
that referenced
this pull request
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix the root cause of #1317:
omni_snapshot_download()(changed by PR #1213) now returns the resolved HF cache path (e.g./root/.cache/huggingface/hub/models--Qwen--Qwen3-TTS-12Hz-1.7B-CustomVoice/snapshots/0c0e...) instead of the original model ID. This breaksqwen3_tts.pywhich parsesmodel_config.modelto extract the task type, and could silently break any other code that expects HuggingFace model ID semantics.Fix: Call
download_weights_from_hf_specific()for its pre-caching side effect but always return the originalmodel_id. Also keep the defensive.split("/")[0]inqwen3_tts.pyas a safeguard.Test Plan
Test Result
Waiting for @Gaohan123 to re-enable the Qwen3-TTS e2e test in CI (disabled in #1306 due to this bug).
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.