-
Notifications
You must be signed in to change notification settings - Fork 509
[Bagel]: Support TP #1293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
hsliuustc0106
merged 9 commits into
vllm-project:main
from
princepride:change-bagel-mlp-tp
Feb 10, 2026
Merged
[Bagel]: Support TP #1293
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
d351c98
replace some layers to vllm version
princepride bbf1242
fix some bug
princepride 950ce0c
Merge branch 'main' into change-bagel-mlp-tp
princepride ae3cc0f
fix some bug
princepride 15ab18e
fix some bug
princepride 4732353
add docs of bagel tp
princepride 71bb46b
commit add tp for mlp and attention part
princepride 311ec53
Merge branch 'main' into change-bagel-mlp-tp
princepride 4b85cfd
Merge branch 'main' into change-bagel-mlp-tp
princepride File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is TP online serving supported by CLI argument like
--tp 2?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am afraid not 😂, CLI argument tp can't overwrite the yaml config:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lishunyang12 Can we overwrite it in the future?