[CI] Refactor test_sequence_parallel.py and add a warmup run for more accurate performance stat#1165
Merged
hsliuustc0106 merged 101 commits intovllm-project:mainfrom Feb 3, 2026
Merged
Conversation
Signed-off-by: mxuax <mxuax@connect.ust.hk>
Signed-off-by: mxuax <mxuax@connect.ust.hk>
Signed-off-by: mxuax <mxuax@connect.ust.hk>
Signed-off-by: mxuax <mxuax@connect.ust.hk>
Signed-off-by: mxuax <mxuax@connect.ust.hk>
… to support cp_plan Signed-off-by: mxuax <mxuax@connect.ust.hk>
…paration in a block Signed-off-by: mxuax <mxuax@connect.ust.hk>
Signed-off-by: mxuax <mxuax@connect.ust.hk>
Signed-off-by: mxuax <mxuax@connect.ust.hk>
Signed-off-by: mxuax <mxuax@connect.ust.hk>
Removed context parallelism plan and related comments. Signed-off-by: XU Mingshi <91017482+mxuax@users.noreply.github.com>
Signed-off-by: XU Mingshi <91017482+mxuax@users.noreply.github.com>
Signed-off-by: mxuax <mxuax@connect.ust.hk>
Signed-off-by: XU Mingshi <91017482+mxuax@users.noreply.github.com>
…llustration Signed-off-by: mxuax <mxuax@connect.ust.hk>
…e lengths - Add sp_attention_mask, sp_padding_size, sp_original_seq_len to ForwardContext - Add auto_pad option to SequenceParallelInput - Implement _shard_with_auto_pad in SequenceParallelSplitHook - Update SequenceParallelGatherHook to remove padding - Update QwenImage _sp_plan with auto_pad=True - Update QwenImageCrossAttention to use sp_attention_mask Signed-off-by: mxuax <mxuax@connect.ust.hk>
Signed-off-by: mxuax <mxuax@connect.ust.hk>
Signed-off-by: mxuax <mxuax@connect.ust.hk>
Signed-off-by: mxuax <mxuax@connect.ust.hk>
Signed-off-by: mxuax <mxuax@connect.ust.hk>
Signed-off-by: mxuax <mxuax@connect.ust.hk>
… code, add some comment Signed-off-by: mxuax <mxuax@connect.ust.hk>
…struction Signed-off-by: mxuax <mxuax@connect.ust.hk>
Signed-off-by: mxuax <mxuax@connect.ust.hk>
Signed-off-by: XU Mingshi <91017482+mxuax@users.noreply.github.com>
Signed-off-by: mxuax <mxuax@connect.ust.hk>
Signed-off-by: mxuax <mxuax@connect.ust.hk>
Signed-off-by: mxuax <mxuax@connect.ust.hk>
Signed-off-by: mxuax <mxuax@connect.ust.hk>
Signed-off-by: mxuax <mxuax@connect.ust.hk>
Signed-off-by: mxuax <mxuax@connect.ust.hk>
Signed-off-by: mxuax <mxuax@connect.ust.hk>
Signed-off-by: mxuax <mxuax@connect.ust.hk>
…e performance stat Signed-off-by: mxuax <mxuax@connect.ust.hk>
Signed-off-by: mxuax <mxuax@connect.ust.hk>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e483ab08fb
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Contributor
Author
|
This PR is ready. @congw729 @wtomin @SamitHuang @ZJY0516 @hsliuustc0106 |
Contributor
|
The codes are fine. Please rebase to origin/main branch to clean the commits log. |
ZJY0516
reviewed
Feb 3, 2026
Signed-off-by: XU Mingshi <91017482+mxuax@users.noreply.github.com>
ZJY0516
approved these changes
Feb 3, 2026
Collaborator
Contributor
futurenitian
pushed a commit
to futurenitian/vllm-omni
that referenced
this pull request
Feb 4, 2026
… accurate performance stat (vllm-project#1165) Signed-off-by: mxuax <mxuax@connect.ust.hk> Signed-off-by: XU Mingshi <91017482+mxuax@users.noreply.github.com> Co-authored-by: Hongsheng Liu <liuhongsheng4@huawei.com> Signed-off-by: future fu <3172516720@qq.com>
futurenitian
pushed a commit
to futurenitian/vllm-omni
that referenced
this pull request
Feb 4, 2026
… accurate performance stat (vllm-project#1165) Signed-off-by: mxuax <mxuax@connect.ust.hk> Signed-off-by: XU Mingshi <91017482+mxuax@users.noreply.github.com> Co-authored-by: Hongsheng Liu <liuhongsheng4@huawei.com> Signed-off-by: future fu <3172516720@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Purpose
This PR refactors test_sequence_parallel.py, and adds a warmup run for more accurate performance stat to fix the issue6 mentioned in #1143. The redundant tests are also removed to speedup the test.
Test Plan
pytest tests/e2e/offline_inference/test_sequence_parallel.py -v -s
Test Result
Hardware: H800
Time duration 388.15s (0:06:28)
NOTE: The performance downgrade is because we use a very small image size(256*256), and the generation bottleneck is communication-bound instead of computational-bound.
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)