[Bug-fix] Fix Bugs in Qwen3/Qwen2.5 Omni Rebased Support#114
Conversation
…ng in omni_stage.py; add M-RoPE position initialization in gpu_model_runner.py
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
vllm_omni/entrypoints/omni_stage.py
Outdated
| # except Exception as e: | ||
| # _logging.getLogger(__name__).exception("[Stage-%s] Failed on batch %s: %s", stage_id, batch_request_ids, e) | ||
| # for rid in batch_request_ids: | ||
| # out_q.put( | ||
| # { |
There was a problem hiding this comment.
Restore stage-level error propagation
The per-batch try/except that previously caught failures in stage_engine.generate and the result-emission loop is now commented out, so any exception during generation or serialization will bubble out of _stage_worker and tear down the stage process without enqueuing {error: ...} responses. When a model throws (e.g., invalid multimodal input or SHM dump failure), the orchestrator will wait indefinitely for results because no downstream error is produced.
Useful? React with 👍 / 👎.
…resolve long lines detected by ruff
Signed-off-by: tzhouam <[email protected]>
…t#114) Signed-off-by: tzhouam <[email protected]>
Purpose
This PR is to fix the 2 bug for Qwen 3 Omni and Qwen 2.5 Omni support.
Test Plan
Test both model on all modalities they support.
For Qwen 2.5:
Modify the "--query-type" in run_single_prompt.sh, the values include mixed_modalities, use_audio_in_video, multi_audios, text.
For Qwen 3:
Modify the "--query-type" in run_single_prompt.sh, the values include text, use_audio, use_image, use_video.
Test Result
The Qwen 3 passed
The Qwen 2.5 passed
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)