[Bugfix] Remove mandatory flash-attn dependency and optimzie docs#113
[Bugfix] Remove mandatory flash-attn dependency and optimzie docs#113tzhouam merged 3 commits intovllm-project:mainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| ROOT_DIR = Path(__file__).parent.parent.parent.parent | ||
| ROOT_DIR_RELATIVE = "../../../../.." | ||
| EXAMPLE_DIR = ROOT_DIR / "examples" | ||
| EXAMPLE_DOC_DIR = ROOT_DIR / "docs/user_guide/examples" | ||
| NAV_FILE = ROOT_DIR / "docs/.nav.yml" |
There was a problem hiding this comment.
The MkDocs hook computes ROOT_DIR by walking four parents from generate_examples.py, which resolves to /workspace instead of the repository root /workspace/vllm-omni. Consequently EXAMPLE_DIR points to /workspace/examples, and on_startup calls EXAMPLE_DIR.iterdir() (line ~310) on a non-existent path, raising FileNotFoundError and aborting mkdocs build/serve before any example docs or nav updates are generated. Please anchor ROOT_DIR at the repo root so the hook can locate examples and .nav.yml.
Useful? React with 👍 / 👎.
Signed-off-by: Gaohan123 <[email protected]>
Signed-off-by: Gaohan123 <[email protected]>
Signed-off-by: Gaohan123 <[email protected]>
Gaohan123
force-pushed
the
flash-attn-fix
branch
from
9103078 to
1d1a89a
Compare
|
lgtm, merging |
…lm-project#113) Signed-off-by: Gaohan123 <[email protected]>
2 participants
Purpose
This PR removes mandatory flash-attn dependency and optimzie docs. Now it can automatically link markdown file in examples to docs and navigation.
Test Plan
Follow README.md in examples of Qwen3-omni.
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)