Skip to content

[Fix] Increase max wait time for server readiness to accommodate model loading#1089

Merged
hsliuustc0106 merged 1 commit intovllm-project:mainfrom
AndyZhou952:lora-ci-time
Jan 30, 2026
Merged

[Fix] Increase max wait time for server readiness to accommodate model loading#1089
hsliuustc0106 merged 1 commit intovllm-project:mainfrom
AndyZhou952:lora-ci-time

Conversation

@AndyZhou952
Copy link
Contributor

PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.

Purpose

Fix #1029 example 10 and follow-up to #1075 . This is introduced by switching to the common OmniServer from test.confest with default max_time=600s (In the CI use case, we increase the time to 1200s to accommodate that in the previous PRs, but it was overwritten - we revert the changes here)

Loading safetensors checkpoint shards: 67% 2/3 [07:35<03:42, 222.93s/it]ERROR/usr/local/lib/python3.12/dist-packages/coverage/control.py:958: CoverageWarning: No data was collected. (no-data-collected); see https://coverage.readthedocs.io/en/7.13.2/messages.html#warning-no-data-collected


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft.

BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)

Signed-off-by: Andy Zhou <46011930+AndyZhou952@users.noreply.github.com>
@yenuo26
Copy link
Contributor

yenuo26 commented Jan 30, 2026

OK

@david6666666 david6666666 added the ready label to trigger buildkite CI label Jan 30, 2026
@david6666666 david6666666 enabled auto-merge (squash) January 30, 2026 02:37
@david6666666 david6666666 disabled auto-merge January 30, 2026 02:37
@david6666666
Copy link
Collaborator

Is there some other issue besides the maximum waiting time?

@AndyZhou952
Copy link
Contributor Author

Is there some other issue besides the maximum waiting time?

Nothing I'm aware of currently. Fingers crossed!

@hsliuustc0106 hsliuustc0106 merged commit c7fb59f into vllm-project:main Jan 30, 2026
7 checks passed
dongbo910220 pushed a commit to dongbo910220/vllm-omni that referenced this pull request Feb 1, 2026
…l loading (vllm-project#1089)

Signed-off-by: Andy Zhou <46011930+AndyZhou952@users.noreply.github.com>
@AndyZhou952 AndyZhou952 deleted the lora-ci-time branch February 5, 2026 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready label to trigger buildkite CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: CI failure collections

4 participants