[CI]: Bagel E2E Smoked Test#1074
Conversation
Signed-off-by: princepride <wangzhipeng628@gmail.com>
Signed-off-by: princepride <wangzhipeng628@gmail.com>
Signed-off-by: princepride <wangzhipeng628@gmail.com>
|
@codex review |
|
@congw729 PTAL |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7915a89633
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Gaohan123
left a comment
There was a problem hiding this comment.
I think it is not a Unit Test, which is just for api check and protection. Your PR is more like an E2E Smoked Test (ST), which is more suitable to put in e2e folder.
Thank you for your feedback, I will change |
Signed-off-by: princepride <wangzhipeng628@gmail.com>
|
@Gaohan123 @congw729 PTAL, I hope this test can be merged as soon as possible to prevent new PR unintentionally modified the relevant code. |
|
@yenuo26 PTAL |
There was a problem hiding this comment.
Pull request overview
This PR adds end-to-end tests for Bagel text-to-image generation to strengthen CI coverage for diffusion-based models. The tests validate image generation output using pixel-level comparisons and support both SharedMemory and Mooncake connectors for inter-stage communication.
Changes:
- Added comprehensive E2E tests for Bagel text2img generation with two connector types (SharedMemory and Mooncake)
- Updated GPU memory utilization in Bagel stage configurations to support single-GPU testing (redistributed from 0.4/0.4 to 0.35/0.55)
- Added Buildkite CI step for automated testing on H100 GPUs
- Added mooncake-transfer-engine dependency to development requirements
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 17 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/e2e/offline_inference/test_bagel_text2img.py | New test file with two test functions validating Bagel text2img generation using reference pixel comparisons |
| vllm_omni/model_executor/stage_configs/bagel.yaml | Adjusted GPU memory utilization to accommodate both stages on single GPU (0.35/0.55 split) |
| vllm_omni/model_executor/stage_configs/bagel_multiconnector.yaml | Updated device allocation to use single GPU and adjusted memory utilization; now both stages run on device 0 |
| .buildkite/pipeline.yml | Added new CI step for Bagel text2img tests on H100 GPU with 30-minute timeout |
| pyproject.toml | Added mooncake-transfer-engine==0.3.8.post1 to dev dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@princepride could you please add the benchmark result for diffusion models under benchmark folder, maybe for the dit-only model |
Signed-off-by: princepride <wangzhipeng628@gmail.com>
DiT-only Model: BAGEL-7B-MoT (Text-to-Image)Hardware: NVIDIA H200 141GB Server command: vllm serve ByteDance-Seed/BAGEL-7B-MoT --omni --port 8099Benchmark command: python3 benchmarks/diffusion/diffusion_benchmark_serving.py \
--base-url http://localhost:8099 \
--model ByteDance-Seed/BAGEL-7B-MoT \
--task t2i \
--dataset vbench \
--num-prompts 5Results: |
|
@hsliuustc0106 PTAL |
Signed-off-by: princepride <wangzhipeng628@gmail.com>
|
|
Please resolve CI failures |
it looks like HF downloading problem |
Signed-off-by: princepride <wangzhipeng628@gmail.com>
Signed-off-by: princepride <wangzhipeng628@gmail.com>
Signed-off-by: princepride <wangzhipeng628@gmail.com>
Signed-off-by: princepride <wangzhipeng628@gmail.com>
|
@hsliuustc0106 Ready to merge. 😊 |
Signed-off-by: princepride <wangzhipeng628@gmail.com> Co-authored-by: Hongsheng Liu <liuhongsheng4@huawei.com>
Purpose
Add E2E Bagel unit test I have discussed in: #400
Add end-to-end unit tests for Bagel text-to-image generation to validate the model's image generation pipeline. This PR includes:
Test Plan
Result