[Bugfix][Test] Re-enable the log simple tests#1065
Merged
Gaohan123 merged 2 commits intovllm-project:mainfrom Jan 29, 2026
Merged
[Bugfix][Test] Re-enable the log simple tests#1065Gaohan123 merged 2 commits intovllm-project:mainfrom
Gaohan123 merged 2 commits intovllm-project:mainfrom
Conversation
Signed-off-by: gcanlin <[email protected]>
Contributor
Author
Contributor
|
So after this PR we don't have CPU tests anymore? |
Contributor
Author
We still need it. But we execute it in GPU queue even if this test don't occur GPU resources. Would it increase the burden on CI? |
Gaohan123
approved these changes
Jan 29, 2026
| @@ -22,8 +22,10 @@ steps: | |||
| commands: | |||
| - pytest -v -s tests/entrypoints/ | |||
Collaborator
There was a problem hiding this comment.
I am curious why both pipeline.yml and simple_test.sh have pytest -v -s tests/entrypoints/ ? Intuitively, simple_test.sh run cpu tests. And pipeline.yml run gpu tests.
dongbo910220
pushed a commit
to dongbo910220/vllm-omni
that referenced
this pull request
Feb 1, 2026
Signed-off-by: gcanlin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.
Purpose
In #774, I change UT to run based on docker container, to avoid the error below(I copy my comment here). But some new tests were only added in
simple_test.sh. I think we can unify the setup of env into Dockerfile and safely removesimple_test.sh. So this PR is aim to recover the remaining tests.The more details: #774 (comment)
Test Plan
CI
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)