[bugfix] remove vllm speech route#1060
Merged
david6666666 merged 1 commit intovllm-project:mainfrom Jan 29, 2026
Merged
Conversation
…vllm-project#1041) Signed-off-by: linyueqian <linyueqian@outlook.com>
a729b28 to
92afee5
Compare
1 task
Collaborator
|
LTGM |
david6666666
approved these changes
Jan 29, 2026
dongbo910220
pushed a commit
to dongbo910220/vllm-omni
that referenced
this pull request
Feb 1, 2026
Signed-off-by: linyueqian <linyueqian@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.
Purpose
Fix 400 Bad Request when calling
/v1/audio/speechwith Qwen3-TTS voices (e.g.,Vivian,Ryan).vllm's built-in
/v1/audio/speechroute validates thevoiceparameter against OpenAI's voice list (alloy,echo,shimmer, etc.), rejecting any Qwen3-TTS voice names. Because vllm-omni never removed this upstream route, vllm's handler took precedence over omni's, which has proper Qwen3-TTS validation.The fix adds
_remove_route_from_router(router, "/v1/audio/speech", {"POST"})before registering omni's speech endpoint, consistent with how/v1/chat/completions,/health, and/v1/modelsare already handled.Fixes #1041 and addresses this comment.
Test Plan
Test Result
test_ryan.wav
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)