[Bugfix] fix qwen image layerd in dummy run#1027
Merged
hsliuustc0106 merged 2 commits intovllm-project:mainfrom Jan 29, 2026
Merged
[Bugfix] fix qwen image layerd in dummy run#1027hsliuustc0106 merged 2 commits intovllm-project:mainfrom
hsliuustc0106 merged 2 commits intovllm-project:mainfrom
Conversation
Signed-off-by: zjy0516 <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #1002 where the Qwen/Qwen-Image-Layered model throws an error during the dummy run phase. The error occurred because the model requires RGBA format images, but the dummy run was creating RGB images. The fix introduces a color_format attribute system that allows models to specify their required image color format.
Changes:
- Added
color_formatclass variable to theSupportImageInputprotocol with a default value of "RGB" - Set
color_format = "RGBA"specifically forQwenImageLayeredPipeline - Implemented
image_color_format()function to retrieve the color format for a model and updated the dummy run to use it - Cleaned up unused logger import and logging statement in the example script
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
vllm_omni/diffusion/models/interface.py |
Added default color_format class variable to SupportImageInput protocol |
vllm_omni/diffusion/models/qwen_image/pipeline_qwen_image_layered.py |
Set color_format = "RGBA" for the layered pipeline |
vllm_omni/diffusion/diffusion_engine.py |
Added image_color_format() function and updated dummy run to use the appropriate color format |
examples/offline_inference/image_to_image/image_edit.py |
Removed unused logger import and logging statement |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fhfuih
approved these changes
Jan 29, 2026
Contributor
fhfuih
left a comment
There was a problem hiding this comment.
I think the current fix is good for now. Thanks
SamitHuang
approved these changes
Jan 29, 2026
Contributor
|
LGTM. |
dongbo910220
pushed a commit
to dongbo910220/vllm-omni
that referenced
this pull request
Feb 1, 2026
Signed-off-by: zjy0516 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
FIX #1002
add
color_formatfor dummy runcc @wtomin @fhfuih @Gaohan123
Test
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)