Skip to content

Conversation

@MengqingCao
Copy link
Collaborator

@MengqingCao MengqingCao commented Nov 28, 2025

What this PR does / why we need it?

Enable chunked prefill for auto-prefix-caching test.

After upgrading the vLLM version to v0.11.2 in #4400, the accuracy on auto-prefix-caching + non-chunked-prefill is broken. Due to chunked prefill is enabled by default, we change the apc test case firstly to recover CI.

After vllm-project/vllm#28833, non-Pooling models won't be able to disable chunked prefill any more.
Maybe we should fix the chunked prefill configuration issue in #4498 together

How was this patch tested?

CI passed with existing test.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables chunked prefill for the auto-prefix-caching test to resolve a CI failure, which is a reasonable approach to get the CI passing. The change un-skips a test and updates it to use chunked prefill. My review includes a suggestion to refactor the test to improve maintainability by reducing code duplication, which will make future modifications easier and less prone to error.

@MengqingCao MengqingCao added ready read for review ready-for-test start test by label for PR labels Nov 28, 2025
@MengqingCao
Copy link
Collaborator Author

@wangxiyuan PTAL

@MengqingCao
Copy link
Collaborator Author

closing as done by #4569

@MengqingCao MengqingCao closed this Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:tests ready read for review ready-for-test start test by label for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant