Skip to content

Conversation

@kyuyeunk
Copy link
Collaborator

@kyuyeunk kyuyeunk commented Sep 19, 2025

Description

vllm-project/vllm#24278 introduces argument prompt_embeds to class NewRequestData with a default argument None: output.py

Due to this change, any new variable that is defined in a child class of NewRequestData (e.g., CachedRequestState) requires a default value.

Otherwise, following error is thrown

(EngineCore_DP0 pid=41591) ERROR 09-19 06:33:33 [core.py:712]   File "/home/kyuyeunk_google_com/workspace/tpu_commons/tpu_commons/runner/input_batch_jax.py", line 25, in <module>
(EngineCore_DP0 pid=41591) ERROR 09-19 06:33:33 [core.py:712]     @dataclass
(EngineCore_DP0 pid=41591) ERROR 09-19 06:33:33 [core.py:712]      ^^^^^^^^^
(EngineCore_DP0 pid=41591) ERROR 09-19 06:33:33 [core.py:712]   File "/home/kyuyeunk_google_com/miniconda3/envs/vllm/lib/python3.12/dataclasses.py", line 1275, in dataclass
(EngineCore_DP0 pid=41591) ERROR 09-19 06:33:33 [core.py:712]     return wrap(cls)
(EngineCore_DP0 pid=41591) ERROR 09-19 06:33:33 [core.py:712]            ^^^^^^^^^
(EngineCore_DP0 pid=41591) ERROR 09-19 06:33:33 [core.py:712]   File "/home/kyuyeunk_google_com/miniconda3/envs/vllm/lib/python3.12/dataclasses.py", line 1265, in wrap
(EngineCore_DP0 pid=41591) ERROR 09-19 06:33:33 [core.py:712]     return _process_class(cls, init, repr, eq, order, unsafe_hash,
(EngineCore_DP0 pid=41591) ERROR 09-19 06:33:33 [core.py:712]            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
(EngineCore_DP0 pid=41591) ERROR 09-19 06:33:33 [core.py:712]   File "/home/kyuyeunk_google_com/miniconda3/envs/vllm/lib/python3.12/dataclasses.py", line 1063, in _process_class
(EngineCore_DP0 pid=41591) ERROR 09-19 06:33:33 [core.py:712]     _init_fn(all_init_fields,
(EngineCore_DP0 pid=41591) ERROR 09-19 06:33:33 [core.py:712]   File "/home/kyuyeunk_google_com/miniconda3/envs/vllm/lib/python3.12/dataclasses.py", line 585, in _init_fn
(EngineCore_DP0 pid=41591) ERROR 09-19 06:33:33 [core.py:712]     raise TypeError(f'non-default argument {f.name!r} '
(EngineCore_DP0 pid=41591) ERROR 09-19 06:33:33 [core.py:712] TypeError: non-default argument 'output_token_ids' follows default argument

Tests

https://buildkite.com/tpu-commons/tpu-commons-ci/builds/3153

Checklist

Before submitting this PR, please make sure:

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have made or will make corresponding changes to any relevant documentation.

@github-actions
Copy link

Description

Start with a short description of what the PR does and how this is a change from
the past.

The rest of the description includes relevant details and context, examples:

  • why is this change being made,
  • the problem being solved and any relevant context,
  • why this is a good solution,
  • some information about the specific implementation,
  • shortcomings of the solution and possible future improvements.

If the change fixes a bug or a Github issue, please include a link, e.g.,:
FIXES: b/123456
FIXES: #123456

Tests

Please describe how you tested this change, and include any instructions and/or
commands to reproduce.

Checklist

Before submitting this PR, please make sure:

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have made or will make corresponding changes to any relevant documentation.

@kyuyeunk
Copy link
Collaborator Author

Closing this as other PR that contains this fix got merged first: #715

@kyuyeunk kyuyeunk closed this Sep 19, 2025
@kyuyeunk kyuyeunk deleted the fix_non_default branch September 20, 2025 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants