Skip to content

Fix building darks library #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vladtcvs merged 1 commit into from
Feb 21, 2025
Merged

Fix building darks library #192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/vstarstack/library/calibration/dark.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,14 +78,13 @@ class FilterSource(vstarstack.library.common.IImageSource):
def __init__(self, source : vstarstack.library.common.IImageSource,
exposure : float,
gain : float,
temperature : float | None,
temperature_idx : int,
temperature_indexer : TemperatureIndex):
self.temperature_indexer = temperature_indexer
self.source = source
self.exposure = exposure
self.gain = gain
self.temperature = temperature
self.temperature_idx = self.temperature_indexer.temperature_to_index(self.temperature)
self.temperature_idx = temperature_idx

def items(self) -> Generator[vstarstack.library.data.DataFrame, None, None]:
for df in self.source.items():
Expand All @@ -111,11 +110,13 @@ def prepare_darks(images : vstarstack.library.common.IImageSource,
gain = df.get_parameter("gain")
temperature = df.get_parameter("temperature")
index = indexer.temperature_to_index(temperature)
logger.info(f"Adding exposure = {exposure}, gain = {gain}, temperature = {temperature}, index = {index}")
parameters.add((exposure, gain, index))

darks = []
for exposure, gain, index in parameters:
image_source = FilterSource(images, exposure, gain, temperature, indexer)
logger.info(f"Processing exposure = {exposure}, gain = {gain}, index = {index}")
image_source = FilterSource(images, exposure, gain, index, indexer)
dark = vstarstack.library.merge.simple_mean.mean(image_source)
dark.add_parameter(exposure, "exposure")
dark.add_parameter(gain, "gain")
Expand Down