Skip to content

[debug dump util] Match Infra and Corresponding UT's added#6

Closed
vivekrnv wants to merge 14 commits intomasterfrom
match_engine
Closed

[debug dump util] Match Infra and Corresponding UT's added#6
vivekrnv wants to merge 14 commits intomasterfrom
match_engine

Conversation

@vivekrnv
Copy link
Copy Markdown
Owner

What I did

HLD for Dump Utility: HLD.

  • Added the Logic for Match Infrastructure along with corresponding unit tests.

For More Info on Match Infrastructure, Check this section in the HLD:
MatchInfra

How I did it

How to verify it

tests/dump_tests/match_engine_test.py::TestInvalidRequest::test_bad_key_pattern PASSED                                                                                                                 [ 83%]
tests/dump_tests/match_engine_test.py::TestInvalidRequest::test_bad_request PASSED                                                                                                                     [ 83%]
tests/dump_tests/match_engine_test.py::TestInvalidRequest::test_invalid_combination PASSED                                                                                                             [ 84%]
tests/dump_tests/match_engine_test.py::TestInvalidRequest::test_invalid_db PASSED                                                                                                                      [ 84%]
tests/dump_tests/match_engine_test.py::TestInvalidRequest::test_just_keys_return_fields_compat PASSED                                                                                                  [ 84%]
tests/dump_tests/match_engine_test.py::TestInvalidRequest::test_no_file PASSED                                                                                                                         [ 84%]
tests/dump_tests/match_engine_test.py::TestInvalidRequest::test_no_source PASSED                                                                                                                       [ 84%]
tests/dump_tests/match_engine_test.py::TestInvalidRequest::test_no_table PASSED                                                                                                                        [ 84%]
tests/dump_tests/match_engine_test.py::TestInvalidRequest::test_no_value PASSED                                                                                                                        [ 84%]
tests/dump_tests/match_engine_test.py::TestInvalidRequest::test_return_fields_bad_format PASSED                                                                                                        [ 84%]
tests/dump_tests/match_engine_test.py::TestInvalidRequest::test_vague_source PASSED                                                                                                                    [ 84%]
tests/dump_tests/match_engine_test.py::TestMatchEngine::test_field_value_match PASSED                                                                                                                  [ 84%]
tests/dump_tests/match_engine_test.py::TestMatchEngine::test_field_value_match_list_type PASSED                                                                                                        [ 85%]
tests/dump_tests/match_engine_test.py::TestMatchEngine::test_field_value_no_match PASSED                                                                                                               [ 85%]
tests/dump_tests/match_engine_test.py::TestMatchEngine::test_file_source PASSED                                                                                                                        [ 85%]
tests/dump_tests/match_engine_test.py::TestMatchEngine::test_file_source_with_key_ptrn PASSED                                                                                                          [ 85%]
tests/dump_tests/match_engine_test.py::TestMatchEngine::test_file_source_with_not_only_return_keys PASSED                                                                                              [ 85%]
tests/dump_tests/match_engine_test.py::TestMatchEngine::test_for_no_key_match PASSED                                                                                                                   [ 85%]
tests/dump_tests/match_engine_test.py::TestMatchEngine::test_for_no_match PASSED                                                                                                                       [ 85%]
tests/dump_tests/match_engine_test.py::TestMatchEngine::test_just_keys_false PASSED                                                                                                                    [ 85%]
tests/dump_tests/match_engine_test.py::TestMatchEngine::test_key_pattern_complex PASSED                                                                                                                [ 85%]
tests/dump_tests/match_engine_test.py::TestMatchEngine::test_key_pattern_wildcard PASSED                                                                                                               [ 85%]
tests/dump_tests/match_engine_test.py::TestMatchEngine::test_return_fields_with_all_filtering PASSED                                                                                                   [ 85%]
tests/dump_tests/match_engine_test.py::TestMatchEngine::test_return_fields_with_field_value_filtering PASSED                                                                                           [ 86%]
tests/dump_tests/match_engine_test.py::TestMatchEngine::test_return_fields_with_key_filtering PASSED                                                                                                   [ 86%]
tests/dump_tests/match_engine_test.py::TestMatchEngine::test_return_keys PASSED                                                                                                                        [ 86%]

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

vivekrnv added 2 commits May 14, 2021 05:02
Signed-off-by: Vivek Reddy Karri <[email protected]>
Signed-off-by: Vivek Reddy Karri <[email protected]>
vivekrnv added 2 commits May 20, 2021 20:09
Signed-off-by: Vivek Reddy Karri <[email protected]>
Signed-off-by: Vivek Reddy Karri <[email protected]>
vivekrnv added 3 commits May 27, 2021 17:22
Signed-off-by: Vivek Reddy Karri <[email protected]>
Signed-off-by: Vivek Reddy Karri <[email protected]>
Copy link
Copy Markdown

@stepanblyschak stepanblyschak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General comment: Run the code against PEP8 checker

vivekrnv added 3 commits June 9, 2021 07:48
Signed-off-by: Vivek Reddy Karri <[email protected]>
Signed-off-by: Vivek Reddy Karri <[email protected]>
Signed-off-by: Vivek Reddy Karri <[email protected]>
Signed-off-by: Vivek Reddy Karri <[email protected]>
Signed-off-by: Vivek Reddy Karri <[email protected]>
@vivekrnv vivekrnv closed this Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants