redo (assert) for better error messages
#274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old:
(assert (= 1 foo))
error: `assertion failed: (= 1 foo)`
New:
(assert = 1 foo)
error: `assertion failed: (= 1 2)`
It's also marked as `^:indent` meaning you can format it like this:
(assert = "1,2,3"
(strings:join "," [1 2 3]))
vito
force-pushed
the
better-assert
branch
4 times, most recently
from
7381ff0 to
a9fd03d
Compare
vito
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old:
(assert (= 1 foo)), error:assertion failed: (= 1 foo)New:
(assert = 1 foo), error:assertion failed: (= 1 2)It's also marked as
^:indentmeaning you can format it like this: