don't ignore caches for services #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the intention here was to prevent accidentally caching a service that exits 0 when interrupted. in reality this also prevented explicit cache mounts from working; they'd always just be empty. cache mounts are required for services that keep state, e.g. Nixery. we also don't want to introduce any randomness to the LLB since that would prevent sharing of resources. it doesn't seem possible to meet all of these constraints at the moment, so just get rid of the cache prevention as I haven't seen it actually cause any problems yet. maybe because we always interrupt the service, and that prevents buildkit from caching even if it exits 0? or maybe everything is just exiting nonzero properly? (none of this is confirmed, but it would be nice!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the intention here was to prevent accidentally caching a service that exits 0 when interrupted.
in reality this also prevented explicit cache mounts from working; they'd always just be empty. cache mounts are required for services that keep state, e.g. Nixery.
we also don't want to introduce any randomness to the LLB since that would prevent sharing of resources.
it doesn't seem possible to meet all of these constraints at the moment, so just get rid of the cache prevention as I haven't seen it actually cause any problems yet. maybe because we always interrupt the service, and that prevents buildkit from caching even if it exits 0? or maybe everything is just exiting nonzero properly? (none of this is confirmed, but it would be nice!)