fix silly cache race #230
Merged
fix silly cache race #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this was obviously broken! we would check if the cache already existed and return it, but then create the cache and start writing to it. now we'll create a temporary file and then rename it over the cache instead. this should fix all the really weird errors hitting bass-loop whenever hooks kick off concurrently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this was obviously broken! we would check if the cache already existed
and return it, but then create the cache and start writing to it.
now we'll create a temporary file and then rename it over the cache
instead.
this will hopefully fix all the really weird errors hitting bass-loop
whenever hooks kick off concurrently.