Skip to content

structured (log) and (error), remove (logf) and (errorf) #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 5, 2022
Merged

structured (log) and (error), remove (logf) and (errorf) #156

merged 8 commits into from
May 5, 2022

Conversation

@vito
Copy link
Owner

@vito vito commented May 5, 2022

  • (logf) and (errorf) were chucked in hastily without any plan really
  • formatting strings beget language spec / implementation complexity (currently tightly coupled to Go's fmt)
  • (log) and (error) now accept kwargs for arbitrary fields
  • structured logs are easier to write and easier to parse
  • structured errors are equally helpful

@vito vito added enhancement New feature or request breaking Removes or replaces previously supported functionality labels May 5, 2022
@vito vito merged commit e9b33e4 into main May 5, 2022
@vito vito deleted the structured-logs-errors branch May 5, 2022 02:46
@vito vito changed the title structured logs and errors, remove (logf) and (errorf) structured (log) and (error), remove (logf) and (errorf) May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

breaking Removes or replaces previously supported functionality enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vito