synchronize cache access by default #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shared is unsafe and is leading to nix failures
really, all 3 cache modes have their use cases, but i think synchronous is the safest default at least. it might make sense to make this configurable on the mount source somehow, instead of just taking over naked file/dir paths.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I kept running into spurious failures with e.g.
"nix" executable not foundwhen builds ran concurrently for the first time.The setting was
sharedwhich is basically "yolo" - everyone gets write access.An alternative is
privatewhich gives each writer their own copy, and I suppose last writer wins?The most conservative option is
lockedwhich ensures only one writer has access at a time, setting the others to wait.I'm sticking with it until someone complains. :)