bass tweaks #150
Merged
bass tweaks #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
vito
commented
Apr 19, 2022
vito
commented
- fix broken 'src' default in bass/ scripts
- loopify bass/shipit
you can't pass a host path like *dir*/../ to a thunk - host paths are limited to their initial context. you can load a bass script that way, since it's bass itself interpreting the path, but thunks will just see an empty directory. this might change at some point; I like it from a safety/security standpoint but eh, we'll see if it's even doing much and worth the gotcha.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.