Skip to content

fix: don't leak event listener in playwright provider #9910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sheremet-va merged 1 commit into from
Mar 19, 2026
+17 −13
Merged

fix: don't leak event listener in playwright provider #9910

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 17 additions & 13 deletions packages/browser-playwright/src/playwright.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,19 +136,21 @@ export class PlaywrightBrowserProvider implements BrowserProvider {
}

// make sure the traces are finished if the test hangs
process.on('SIGTERM', () => {
if (!this.browser) {
return
}
const promises = []
for (const [trace, contextId] of this.pendingTraces.entries()) {
promises.push((() => {
const context = this.contexts.get(contextId)
return context?.tracing.stopChunk({ path: trace })
})())
}
return Promise.allSettled(promises)
})
process.on('SIGTERM', this.onSIGTERM)
}

private onSIGTERM = () => {
if (!this.browser) {
return
}
const promises = []
for (const [trace, contextId] of this.pendingTraces.entries()) {
promises.push((() => {
const context = this.contexts.get(contextId)
return context?.tracing.stopChunk({ path: trace })
})())
}
return Promise.allSettled(promises)
}

private async openBrowser(openBrowserOptions: { parallel: boolean }) {
Expand Down Expand Up @@ -545,6 +547,8 @@ export class PlaywrightBrowserProvider implements BrowserProvider {
}

async close(): Promise<void> {
process.off('SIGTERM', this.onSIGTERM)

debug?.('[%s] closing provider', this.browserName)
this.closing = true
if (this.browserPromise) {
Expand Down
Loading