-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix(browser-preview): display url with the sessionId #8977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
userquin
wants to merge
7
commits into
main
Choose a base branch
from
userquin/fix-missing-session-id-with-preview-provider
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
fix(browser-preview): display url with the sessionId #8977
userquin
wants to merge
7
commits into
main
from
userquin/fix-missing-session-id-with-preview-provider
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@vitest/browser
@vitest/browser-playwright
@vitest/browser-preview
@vitest/browser-webdriverio
@vitest/coverage-istanbul
@vitest/coverage-v8
@vitest/expect
@vitest/mocker
@vitest/pretty-format
@vitest/runner
@vitest/snapshot
@vitest/spy
@vitest/ui
@vitest/utils
vitest
@vitest/web-worker
@vitest/ws-client
commit: |
Member
Author
|
We need to fix |
Member
Author
|
We need to show a warning in the temrinal when using |
userquin
commented
Nov 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the first session id to the url when starting the browser mode (terminal).
Looks like
openBrowser(Vite) is able to open the browser usingprocess.env.BROWSERand so we need to change the documentation; for example, I don't have Chromium installed, but I was runningtest/browserwith PW and Chromimum, when switching topreview-providerthe browser not being opened. Check the screenshot below, usingset BROWSER=firefox(or running the new scriptnr test:browser:preview:firefox).NOTE: I need to check
previewprovider at StackBlitz.Is there a way to know what instance is running? There is no way to start the corresponding browser instance from the preview provider.Usethis.project.config.browser.nameResolves #issue-number
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.