fix(browser): locator which does not locate any element is not visible #8952
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using an assertion such as
expect(page.getByTestId('not-existing')).not.toBeVisible(), the assertion used to fail because the assertion tried to get the element of the locator, which threw an exception. After this fix, the assertion will pass, because an element that does not exist (and which is thus not in the document) is de facto not visible. It allows the developer to usenot.toBeVisible()without having to care if the element is hidden in the DOM or removed from the DOM.See #8946 (comment)
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci. but so many tests are failing that can't possibly come from the tiny fix I introducedDocumentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.