Skip to content

Conversation

@AriPerkkio
Copy link
Member

@AriPerkkio AriPerkkio commented Oct 27, 2025

Description

Artificial setup with 1000 testfiles which each have 4 empty test cases:

// Before
Test Files  1000 passed (1000)
     Tests  4000 passed (4000)
  Start at  15:31:04
  Duration  5.38s (transform 993ms, setup 0ms, collect 1.85s, tests 76ms, environment 6ms, prepare 51ms)

// After
Test Files  1000 passed (1000)
     Tests  4000 passed (4000)
  Start at  15:31:48
  Duration  4.05s (transform 1.00s, setup 0ms, collect 1.86s, tests 77ms, environment 0ms, prepare 2ms)

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link

netlify bot commented Oct 27, 2025

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 890eade
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/68ff7235c46139000849c285
😎 Deploy Preview https://deploy-preview-8835--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@AriPerkkio AriPerkkio force-pushed the perf/non-isolated-single-worker branch from 5165bb4 to 9a20153 Compare October 27, 2025 09:34
@sheremet-va
Copy link
Member

Does this also fix #8478 ?

@AriPerkkio AriPerkkio force-pushed the perf/non-isolated-single-worker branch 3 times, most recently from 089f935 to 63815c4 Compare October 27, 2025 12:47
@AriPerkkio
Copy link
Member Author

AriPerkkio commented Oct 27, 2025

Does this also fix #8478 ?

With the example from #8478 (comment) I think it does. On main both of these log false.

@AriPerkkio AriPerkkio force-pushed the perf/non-isolated-single-worker branch from 63815c4 to 890eade Compare October 27, 2025 13:23
@AriPerkkio AriPerkkio marked this pull request as ready for review October 27, 2025 13:23
@sheremet-va sheremet-va merged commit 584aa71 into vitest-dev:main Oct 28, 2025
11 of 14 checks passed
@AriPerkkio AriPerkkio deleted the perf/non-isolated-single-worker branch October 28, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Share a single jsdom between suites when running as --no-isolate

2 participants