Skip to content

Conversation

@hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Sep 10, 2025

Description

The top level ./* includes all the build output vitest/dist/.... Limiting this should prevent IDE completion from picking up cryptic names directly from those files, for example:

import { V } from 'vitest/dist/chunks/reporters.d.BFLkQcL6.js';
image

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link

netlify bot commented Sep 10, 2025

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ed5aca5
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/68c11076f2608f0008fc64e5
😎 Deploy Preview https://deploy-preview-8560--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@hi-ogawa hi-ogawa marked this pull request as ready for review September 10, 2025 07:02
@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 11, 2025

@vitest/browser

npm i https://pkg.pr.new/@vitest/browser@8560

@vitest/coverage-istanbul

npm i https://pkg.pr.new/@vitest/coverage-istanbul@8560

@vitest/coverage-v8

npm i https://pkg.pr.new/@vitest/coverage-v8@8560

@vitest/expect

npm i https://pkg.pr.new/@vitest/expect@8560

@vitest/mocker

npm i https://pkg.pr.new/@vitest/mocker@8560

@vitest/pretty-format

npm i https://pkg.pr.new/@vitest/pretty-format@8560

@vitest/runner

npm i https://pkg.pr.new/@vitest/runner@8560

@vitest/snapshot

npm i https://pkg.pr.new/@vitest/snapshot@8560

@vitest/spy

npm i https://pkg.pr.new/@vitest/spy@8560

@vitest/ui

npm i https://pkg.pr.new/@vitest/ui@8560

@vitest/utils

npm i https://pkg.pr.new/@vitest/utils@8560

vite-node

npm i https://pkg.pr.new/vite-node@8560

vitest

npm i https://pkg.pr.new/vitest@8560

@vitest/web-worker

npm i https://pkg.pr.new/@vitest/web-worker@8560

@vitest/ws-client

npm i https://pkg.pr.new/@vitest/ws-client@8560

commit: 892e6ba

Copy link
Member

@AriPerkkio AriPerkkio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the preview build and it seems to fix this!

Usually changes in exports are a breaking change but this is a clear bug fix instead.

@sheremet-va sheremet-va merged commit ce74664 into vitest-dev:main Sep 11, 2025
21 of 26 checks passed
@hi-ogawa hi-ogawa deleted the 09-10-fix_remove_wildcard_exports_.__from_vitest_package branch September 11, 2025 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants