Skip to content

Conversation

@hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Aug 3, 2025

Description

Vitest should avoid settings esbuild on rolldown-vite since that would be overwritten by users or other plugins oxc and it causes noisy warning as more plugins started to adopt oxc option. When Vitest configures oxc, it overwrites user's esbuild option instead, but that's probably fine since rolldown-vite is opt-in and users (and ecosystem in general) should adopt to oxc option.

Regarding oxc.target, I just found it doesn't seem to affect using transpilation vitejs/rolldown-vite#352. We should wait until if the behavior is expected there.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link

netlify bot commented Aug 3, 2025

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit af11ccb
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/68907e0d6497540008f469b9
😎 Deploy Preview https://deploy-preview-8378--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@hi-ogawa hi-ogawa marked this pull request as ready for review August 4, 2025 09:32
@sheremet-va sheremet-va merged commit e922e92 into vitest-dev:main Aug 4, 2025
21 of 24 checks passed
@hi-ogawa hi-ogawa deleted the fix-rolldown-vite-oxc-options branch August 4, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants