Skip to content

Conversation

@thejackshelton
Copy link
Contributor

Description

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link

netlify bot commented Jul 21, 2025

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ae1f3aa
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/687e8373935f3100083980a2
😎 Deploy Preview https://deploy-preview-8330--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sheremet-va
Copy link
Member

sheremet-va commented Jul 21, 2025

By the way, you can also add an example here: https://github.com/vitest-tests/browser-examples

This is where we actually run them. They should probably be generated automatically though 😄

@thejackshelton thejackshelton marked this pull request as draft July 21, 2025 16:02
@thejackshelton
Copy link
Contributor Author

thejackshelton commented Jul 21, 2025

@sheremet-va which command automatically creates the example? I see the all the tests scripts locally, and they pass, including the test file mentioned earlier.

Also not sure why the rolldown test is failing specifically in ci 🤔 . I notice the same action failing in other PR's, maybe we need to re-run the action?

@thejackshelton thejackshelton marked this pull request as ready for review July 21, 2025 18:37
@sheremet-va
Copy link
Member

@sheremet-va which command automatically creates the example? I see the all the tests scripts locally, and they pass, including the test file mentioned earlier.

There is no command that does this automatically. I didn't propose you do it automatically, I noticed that we should generate them automatically 😄

@sheremet-va sheremet-va merged commit 1638b44 into vitest-dev:main Jul 22, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants