Skip to content

Conversation

@AriPerkkio
Copy link
Member

Description

This is a breaking change to improve overall user experience. It makes sense to start the test run when --standalone is used with CLI filename filter.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@AriPerkkio AriPerkkio added this to the 4.0.0 milestone Jul 5, 2025
Comment on lines +153 to +155
if (options.standalone && (cliFilters?.length || 0) > 0) {
options.standalone = false
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seemed like the best place to do this. The resolveConfig doesn't have cliFilters in the scope.

@netlify
Copy link

netlify bot commented Jul 5, 2025

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 947746f
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/6874eac21eacd30008b2d37b
😎 Deploy Preview https://deploy-preview-8262--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@AriPerkkio AriPerkkio force-pushed the fix/standalone-with-filter branch 2 times, most recently from 9b8aafc to e2aa332 Compare July 5, 2025 07:39
@AriPerkkio AriPerkkio force-pushed the fix/standalone-with-filter branch from e2aa332 to 8e2bd87 Compare July 5, 2025 07:41
@AriPerkkio AriPerkkio changed the title fix!: ignode --standalone when CLI filename filter is used fix!: ignore --standalone when CLI filename filter is used Jul 5, 2025
sheremet-va
sheremet-va previously approved these changes Jul 14, 2025
Copy link
Member

@sheremet-va sheremet-va left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add a note to the migration guide?

@sheremet-va sheremet-va merged commit 013bf2c into vitest-dev:main Jul 15, 2025
13 of 14 checks passed
@AriPerkkio AriPerkkio deleted the fix/standalone-with-filter branch July 15, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support standalone + a filename pattern in the CLI

2 participants