-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fix(wdio): don't scale browser in headless mode #8033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(wdio): don't scale browser in headless mode #8033
Conversation
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
|
||
| await expect.element(secondPost.getByRole('heading')).toHaveTextContent('qui est esse') | ||
|
|
||
| // TODO: click doesn't work on webdriverio when iframe is scaled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically the scaling issue still exists for with headed UI. This test still fails locally with:
PROVIDER=webdriverio BROWSER=chrome pnpm -C test/browser test-locators --browser.headless=falseThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I noticed that headless sometimes works differently, but seems like the positions are always incorrect even in dev, you are right. I will revert the scaling for webdriverio provider for now, and we can investigate other solutions later
|
TODO: need to check if playwright and preview keeps working correctly after the webdriverio changes |
hi-ogawa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed PROVIDER=webdriverio BROWSER=chrome pnpm -C test/browser test-locators --browser.headless=false passed locally 👍
Description
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.