Skip to content

Conversation

@hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented May 3, 2025

Description

Testing vitejs/vite#19996 on Vitest. I mainly wonder if this extra function indirection can affect coverage or something.

CI is passing both on current Vite e3c3f16 and new Vite 1621e2a

I think we can release this before Vite's breaking change since it's not much of a breaking change by adding this on vite-node side.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link

netlify bot commented May 3, 2025

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 30b709c
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/6815e8f4c1b30c0008caf2e0
😎 Deploy Preview https://deploy-preview-7925--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pkg-pr-new
Copy link

pkg-pr-new bot commented May 3, 2025

@vitest/browser

npm i https://pkg.pr.new/@vitest/browser@7925

@vitest/coverage-istanbul

npm i https://pkg.pr.new/@vitest/coverage-istanbul@7925

@vitest/expect

npm i https://pkg.pr.new/@vitest/expect@7925

@vitest/mocker

npm i https://pkg.pr.new/@vitest/mocker@7925

@vitest/coverage-v8

npm i https://pkg.pr.new/@vitest/coverage-v8@7925

@vitest/pretty-format

npm i https://pkg.pr.new/@vitest/pretty-format@7925

@vitest/runner

npm i https://pkg.pr.new/@vitest/runner@7925

@vitest/snapshot

npm i https://pkg.pr.new/@vitest/snapshot@7925

@vitest/spy

npm i https://pkg.pr.new/@vitest/spy@7925

@vitest/ui

npm i https://pkg.pr.new/@vitest/ui@7925

@vitest/utils

npm i https://pkg.pr.new/@vitest/utils@7925

vite-node

npm i https://pkg.pr.new/vite-node@7925

vitest

npm i https://pkg.pr.new/vitest@7925

@vitest/web-worker

npm i https://pkg.pr.new/@vitest/web-worker@7925

@vitest/ws-client

npm i https://pkg.pr.new/@vitest/ws-client@7925

commit: e0bb432

sheremet-va
sheremet-va previously approved these changes May 3, 2025
@hi-ogawa hi-ogawa added the p2-to-be-discussed Enhancement under consideration (priority) label May 3, 2025
@hi-ogawa hi-ogawa moved this to P2 - 2 in Team Board May 3, 2025
@sheremet-va sheremet-va merged commit 7609107 into vitest-dev:main May 23, 2025
13 of 14 checks passed
@hi-ogawa hi-ogawa deleted the fix__vite_ssr_exportName__ branch May 24, 2025 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cr-tracked p2-to-be-discussed Enhancement under consideration (priority)

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants