Skip to content

Conversation

@sheremet-va
Copy link
Member

@sheremet-va sheremet-va commented Feb 27, 2025

Description

This PR removes msw from dependencies and instead uses provider APIs to intercept requests for module mocking purposes.

  • playwright uses page.route
  • webdriverio/preview use the default server interceptor

This reduces the amount of dependencies @vitest/browser needs and speeds up the module mocking in playwright because we don't need to import msw

Closes #7556

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link

netlify bot commented Feb 27, 2025

Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit 47f2f0f
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/67e57a31ba35cd0008d44cb7
😎 Deploy Preview https://deploy-preview-7576--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sheremet-va sheremet-va marked this pull request as ready for review March 27, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Require a separate installation of MSW

1 participant