-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: add diff.maxDepth option and set non-Infinity value as a default to reduce crash
#7481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
@vitest/browser
@vitest/coverage-istanbul
@vitest/expect
@vitest/mocker
@vitest/pretty-format
@vitest/coverage-v8
@vitest/runner
@vitest/snapshot
@vitest/spy
@vitest/ui
@vitest/utils
vite-node
@vitest/web-worker
vitest
@vitest/ws-client
commit: |
maxDepth to avoid large diffmaxDepth to avoid large diff
maxDepth to avoid large diffdiff.maxDepth option
diff.maxDepth option diff.maxDepth option and set non-Infinity value as a default to reduce crash
sheremet-va
approved these changes
Mar 3, 2025
1 task
This was referenced May 29, 2025
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I chose default
20for mostly arbitrary reason. We want this as large as possible to be able to print diff that only happens in a deeper level, but the default should be a safer side from crash.This default value is likely still too big for worst cases, but at least, OP's repro get smooth with this https://stackblitz.com/edit/vitest-dev-vitest-cewwclhz?file=test%2Fsuite.test.js.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.