fix(snapshot): allow inline snapshot calls on same location with same snapshot

packages/snapshot/src/port/state.ts

@@ -178,11 +178,14 @@ export default class SnapshotState {
   ): void {
     this._dirty = true
     if (options.stack) {
-      this._inlineSnapshots.push({
-        snapshot: receivedSerialized,
-        testId: options.testId,
-        ...options.stack,
-      })
+      // In a clean state, we don't want to set the inlineSnapshots 2 times
+      if (this._inlineSnapshotStacks.some(s => s.file === options.stack!.file && s.line === options.stack!.line && s.column === options.stack!.column)) {
+        this._inlineSnapshots.push({
+          snapshot: receivedSerialized,
+          testId: options.testId,
+          ...options.stack,
+        })
+      }
     }
     else if (options.rawSnapshot) {
       this._rawSnapshots.push({
@@ -343,12 +346,6 @@ export default class SnapshotState {
       // https://github.com/vitejs/vite/issues/8657
       stack.column--
 
-      // reject multiple inline snapshots at the same location
-      if (this._inlineSnapshotStacks.some(s => s.file === stack!.file && s.line === stack!.line && s.column === stack!.column)) {
-        // remove already succeeded snapshot
-        this._inlineSnapshots = this._inlineSnapshots.filter(s => !(s.file === stack!.file && s.line === stack!.line && s.column === stack!.column))
-        throw new Error('toMatchInlineSnapshot cannot be called multiple times at the same location.')
-      }
       this._inlineSnapshotStacks.push({ ...stack, testId })
     }
 

test/cli/fixtures/fails/inline-snapshop-inside-loop.test.ts

@@ -1,31 +1,7 @@
 import {test, expect} from "vitest";
 
 test("fail 1", () => {
-  for (const str of ["foo", "bar"]) {
-    expect(str).toMatchInlineSnapshot();
-  }
-});
-
-test("fail 2.1", () => {
   for (const str of ["foo", "bar"]) {
     expect(str).toMatchInlineSnapshot(`"foo"`);
   }
-});
-
-test("fail 2.2", () => {
-  for (const str of ["foo", "bar"]) {
-    expect(str).toMatchInlineSnapshot(`"bar"`);
-  }
-});
-
-test("fail 3", () => {
-  for (const str of ["ok", "ok"]) {
-    expect(str).toMatchInlineSnapshot();
-  }
-});
-
-test("fail 4", () => {
-  for (const str of ["ok", "ok"]) {
-    expect(str).toMatchInlineSnapshot(`"ok"`);
-  }
-});
+});

test/cli/test/__snapshots__/fails.test.ts.snap

@@ -50,13 +50,7 @@ Error: InlineSnapshot cannot be used inside of test.each or describe.each
 Error: InlineSnapshot cannot be used inside of test.each or describe.each"
 `;
 
-exports[`should fail inline-snapshop-inside-loop.test.ts 1`] = `
-"Error: toMatchInlineSnapshot cannot be called multiple times at the same location.
-Error: toMatchInlineSnapshot cannot be called multiple times at the same location.
-Error: toMatchInlineSnapshot cannot be called multiple times at the same location.
-Error: toMatchInlineSnapshot cannot be called multiple times at the same location.
-Error: toMatchInlineSnapshot cannot be called multiple times at the same location."
-`;
+exports[`should fail inline-snapshop-inside-loop.test.ts 1`] = `"Error: Snapshot \`fail 1 2\` mismatched"`;
 
 exports[`should fail mock-import-proxy-module.test.ts 1`] = `"Error: There are some problems in resolving the mocks API."`;
 

test/cli/test/fails.test.ts

@@ -9,10 +9,7 @@ const root = resolve(__dirname, '../fixtures/fails')
 const files = await glob(['**/*.test.ts'], { cwd: root, dot: true, expandDirectories: false })
 
 it.each(files)('should fail %s', async (file) => {
-  const { stderr } = await runVitest({
-    root,
-    update: file === 'inline-snapshop-inside-loop.test.ts' ? true : undefined,
-  }, [file])
+  const { stderr } = await runVitest({ root }, [file])
 
   expect(stderr).toBeTruthy()
   const msg = String(stderr)