Skip to content

Conversation

@kemuridama
Copy link
Contributor

@kemuridama kemuridama commented Feb 3, 2025

Description

Jest v30 planned to introduce %$ option which adds the number of the test to its title within each() method by jestjs/jest#14710. This PR imports this feature into Vitest.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link

netlify bot commented Feb 3, 2025

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 3669459
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/67a411bbf775190008298266
😎 Deploy Preview https://deploy-preview-7412--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kemuridama kemuridama changed the title Introduce %$ option to add number of the test to its title feat: Introduce %$ option to add number of the test to its title Feb 3, 2025
@kemuridama
Copy link
Contributor Author

@hi-ogawa Thank you for your review. I think I probably resolved your feedbacks.

@kemuridama kemuridama requested a review from hi-ogawa February 6, 2025 01:36
Copy link
Contributor

@hi-ogawa hi-ogawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sheremet-va sheremet-va added this to the 3.1.0 milestone Feb 7, 2025
@sheremet-va sheremet-va merged commit df34770 into vitest-dev:main Mar 17, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants