refactor!: require fake timers for mocking date #7404
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WIP
While checking #7329, I was slightly confused about this feature allowing mocking date
vi.setSystemTimewithoutvi.useFakeTimers. I'd assume historically Vitest had "mockdate" feature (vi.mockCurrentDate), which is later replaced with Jest-like APIvi.setSystemTime#531, but then that requiredvi.useFakeTimers, sovi.setSystemTimeonly mocking is added back in #639.Having two system internally (and two flags
_fakingTimeand_fakingDate) looks confusing and maybe removing this is fine later time on breaking change. Users can probably migrate tovi.useFakeTimers({ toFake: ["Date"] }).Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.