fix: compat for jest-image-snapshot #7390

hi-ogawa · 2025-01-31T04:33:57Z

Description

closes vitest v3 throws with jest-image-snapshot. #7322

It doesn't look pretty but some sort of compat might be possible on Vitest side.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
Ideally, include a test that fails without this PR but passes with it.
Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

Run the tests with pnpm test:ci.

Documentation

If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

netlify · 2025-01-31T04:36:19Z

✅ Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`3f2d18e`
🔍 Latest deploy log	https://app.netlify.com/sites/vitest-dev/deploys/679c6665a5b36900088dda03
😎 Deploy Preview	https://deploy-preview-7390--vitest-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

pkg-pr-new · 2025-01-31T06:25:01Z

@vitest/browser

npm i https://pkg.pr.new/@vitest/browser@7390

@vitest/coverage-istanbul

npm i https://pkg.pr.new/@vitest/coverage-istanbul@7390

@vitest/expect

npm i https://pkg.pr.new/@vitest/expect@7390

@vitest/coverage-v8

npm i https://pkg.pr.new/@vitest/coverage-v8@7390

@vitest/mocker

npm i https://pkg.pr.new/@vitest/mocker@7390

@vitest/pretty-format

npm i https://pkg.pr.new/@vitest/pretty-format@7390

@vitest/runner

npm i https://pkg.pr.new/@vitest/runner@7390

@vitest/snapshot

npm i https://pkg.pr.new/@vitest/snapshot@7390

@vitest/spy

npm i https://pkg.pr.new/@vitest/spy@7390

@vitest/ui

npm i https://pkg.pr.new/@vitest/ui@7390

@vitest/utils

npm i https://pkg.pr.new/@vitest/utils@7390

vite-node

npm i https://pkg.pr.new/vite-node@7390

vitest

npm i https://pkg.pr.new/vitest@7390

@vitest/web-worker

npm i https://pkg.pr.new/@vitest/web-worker@7390

@vitest/ws-client

npm i https://pkg.pr.new/@vitest/ws-client@7390

commit: 6082d7f

rmariuzzo

LGTM

@hi-ogawa

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@vitest/coverage-v8](https://github.com/vitest-dev/vitest/tree/main/packages/coverage-v8#readme) ([source](https://github.com/vitest-dev/vitest/tree/HEAD/packages/coverage-v8)) | devDependencies | patch | [`3.0.5` -> `3.0.7`](https://renovatebot.com/diffs/npm/@vitest%2fcoverage-v8/3.0.5/3.0.7) | | [vitest](https://github.com/vitest-dev/vitest) ([source](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest)) | devDependencies | patch | [`3.0.5` -> `3.0.7`](https://renovatebot.com/diffs/npm/vitest/3.0.5/3.0.7) | --- ### Release Notes <details> <summary>vitest-dev/vitest (@vitest/coverage-v8)</summary> ### [`v3.0.7`](https://github.com/vitest-dev/vitest/releases/tag/v3.0.7) [Compare Source](vitest-dev/vitest@v3.0.6...v3.0.7) ##### 🐞 Bug Fixes - **browser**: Support webdriverio 9 - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#7553 [<samp>(b1949)</samp>](vitest-dev/vitest@b1949c97) - **deps**: Update all non-major dependencies - in vitest-dev/vitest#7543 [<samp>(365ff)</samp>](vitest-dev/vitest@365ffe6b) - **expect**: Correct generic MatchersObject this type in expect.extend - by [@Workingstiff-s](https://github.com/Workingstiff-s) in vitest-dev/vitest#7526 [<samp>(d5765)</samp>](vitest-dev/vitest@d5765f71) - **mocker**: Include more modules to prefix-only module list - by [@btea](https://github.com/btea) in vitest-dev/vitest#7524 [<samp>(a12ec)</samp>](vitest-dev/vitest@a12ec008) - **spy**: Clear/reset/restore mocks in stack order - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7499 [<samp>(f7100)</samp>](vitest-dev/vitest@f71004ff) ##### 🏎 Performance - **browser**: Do wdio context switching only once per file - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#7549 [<samp>(aaa58)</samp>](vitest-dev/vitest@aaa58556) ##### [View changes on GitHub](vitest-dev/vitest@v3.0.6...v3.0.7) ### [`v3.0.6`](https://github.com/vitest-dev/vitest/releases/tag/v3.0.6) [Compare Source](vitest-dev/vitest@v3.0.5...v3.0.6) ##### 🐞 Bug Fixes - Fix `getMockedSystemTime` for `useFakeTimer` - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7405 [<samp>(03912)</samp>](vitest-dev/vitest@03912b43) - Compat for jest-image-snapshot - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7390 [<samp>(9542b)</samp>](vitest-dev/vitest@9542b699) - Ensure project names are readable in dark terminals - by [@rgrove](https://github.com/rgrove) in vitest-dev/vitest#7371 [<samp>(bb94c)</samp>](vitest-dev/vitest@bb94c19f) - Exclude `queueMicrotask` from default fake timers to not break node fetch - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7505 [<samp>(167a9)</samp>](vitest-dev/vitest@167a98d7) - **browser**: - Fix mocking modules out of root - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7415 [<samp>(d3acb)</samp>](vitest-dev/vitest@d3acbd8b) - Fix `toHaveClass` typing - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7383 [<samp>(7ef23)</samp>](vitest-dev/vitest@7ef238c0) - Relax locator selectors methods - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#7422 [<samp>(1b8c5)</samp>](vitest-dev/vitest@1b8c5c9e) - Resolve thread count from `maxWorkers` - by [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#7483 [<samp>(adbb2)</samp>](vitest-dev/vitest@adbb25ab) - Cleanup timeout on resolve and give more information in the error - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#7487 [<samp>(5a45a)</samp>](vitest-dev/vitest@5a45a7ca) - **coverage**: - `vite-node` to pass correct execution wrapper offset - by [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#7417 [<samp>(1f2e5)</samp>](vitest-dev/vitest@1f2e5552) - Preserve moduleExecutionInfo in non-isolated runs - by [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#7486 [<samp>(f31a0)</samp>](vitest-dev/vitest@f31a07bb) - **deps**: - Update all non-major dependencies - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7363 [<samp>(e348b)</samp>](vitest-dev/vitest@e348bd4c) - Update all non-major dependencies - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7507 [<samp>(6cc40)</samp>](vitest-dev/vitest@6cc408d6) - **init**: - Invalid browser config - by [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#7475 [<samp>(8fe64)</samp>](vitest-dev/vitest@8fe641b4) - **reporters**: - Render tasks in tree when in TTY - by [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#7503 [<samp>(027ce)</samp>](vitest-dev/vitest@027ce9bb) - **vite-node**: - Remove fake first line mapping on Vite 6 - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7124 [<samp>(b9973)</samp>](vitest-dev/vitest@b997355b) - **watch**: - Properly remove cache after removing existing test files - by [@soc221b](https://github.com/soc221b) in vitest-dev/vitest#7399 [<samp>(01a59)</samp>](vitest-dev/vitest@01a59721) - **workspace**: - Forward `inspect` related cli options - by [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#7373 [<samp>(ed15b)</samp>](vitest-dev/vitest@ed15b5b3) ##### [View changes on GitHub](vitest-dev/vitest@v3.0.5...v3.0.6) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://gitea.justinelmore.dev/jelmore1674/build-changelog/pulls/91 Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>

fix: compat for jest-image-snapshot

31c078f

hi-ogawa added 5 commits January 31, 2025 14:40

test: add test

a3d6f5a

fix: no number hint

3f2d18e

refactor: compact

10c9472

chore: comment

e132c3c

chore: cleanup

e52032d

hi-ogawa added the cr-tracked label Jan 31, 2025

test: add test

6082d7f

hi-ogawa marked this pull request as ready for review January 31, 2025 07:14

rmariuzzo approved these changes Jan 31, 2025

View reviewed changes

hi-ogawa mentioned this pull request Feb 1, 2025

vitest v3 throws with jest-image-snapshot. #7322

Closed

6 tasks

sheremet-va approved these changes Feb 4, 2025

View reviewed changes

sheremet-va merged commit 9542b69 into vitest-dev:main Feb 4, 2025
14 checks passed

hi-ogawa deleted the fix-jest-image-snapshot branch February 4, 2025 23:22

renovate bot mentioned this pull request Feb 20, 2025

fix(deps): update all non-major dependencies binoy14/binoy.io#296

Merged

1 task

renovate bot mentioned this pull request Jul 21, 2025

chore: update dependency @vitest/ui to v4 hacomono-lib/json-origami#204

Open

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: compat for jest-image-snapshot #7390

fix: compat for jest-image-snapshot #7390

Uh oh!

hi-ogawa commented Jan 31, 2025 •

edited

Loading

Uh oh!

netlify bot commented Jan 31, 2025 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Jan 31, 2025 •

edited

Loading

Uh oh!

rmariuzzo left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

fix: compat for jest-image-snapshot #7390

fix: compat for jest-image-snapshot #7390

Uh oh!

Conversation

hi-ogawa commented Jan 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

Tests

Documentation

Changesets

Uh oh!

netlify bot commented Jan 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for vitest-dev ready!

Uh oh!

pkg-pr-new bot commented Jan 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rmariuzzo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hi-ogawa commented Jan 31, 2025 •

edited

Loading

netlify bot commented Jan 31, 2025 •

edited

Loading

pkg-pr-new bot commented Jan 31, 2025 •

edited

Loading