Skip to content

Conversation

@hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Jan 21, 2025

Description

I'm not sure why CI is failing with Ubuntu Node 22. Locally, this test is passing on my Arch Linux PC with Node 22 (Oh, maybe it was just flaky. CI passed now.)

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

fix: shouldHandle cannot be async

wip: copy isHostAllowed

chore: move code

chore: comment

wip: allow only same origin

chore: cleanup

wip: isApiRequestAllowed

chore: cleanup

wip: switch to token check

chore: unused

fix: inject VITEST_API_TOKEN in orchestrator ui

docs: add api.allowedHosts

fix: require token for __vitest_browser_api__ request

chore: cleanup

refactor: combine to isWebsocketRequestAllowed
@hi-ogawa hi-ogawa mentioned this pull request Jan 21, 2025
6 tasks
@netlify
Copy link

netlify bot commented Jan 21, 2025

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit e2bd89c
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/679194be5007860008b3b787
😎 Deploy Preview https://deploy-preview-7318--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hi-ogawa hi-ogawa force-pushed the fix-vitest-ghsa-9crc-q9x8-hgqq-v2 branch from 377b29d to cac016a Compare January 21, 2025 03:50
@hi-ogawa hi-ogawa marked this pull request as ready for review January 21, 2025 05:12
@hi-ogawa hi-ogawa force-pushed the fix-vitest-ghsa-9crc-q9x8-hgqq-v2 branch from 910c502 to e2bd89c Compare January 23, 2025 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants