Skip to content

fix(browser): add instance validation to resolve coverage error #7231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 15, 2025
Merged

fix(browser): add instance validation to resolve coverage error #7231

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6ee2838
fix (coverage-v8): add instance validation to resolve error
DevJoaoLopes Jan 13, 2025
d808bb3
fix (coverage-v8): add instance validation to resolve error
DevJoaoLopes Jan 13, 2025
02c49d0
feat: add new message in error
DevJoaoLopes Jan 13, 2025
986e4c8
Merge branch 'main' into fix/coverage-v8-instances-config
DevJoaoLopes Jan 13, 2025
583896e
fix: review
AriPerkkio Jan 15, 2025
27c0502
Merge remote-tracking branch 'upstream/main' into fix/coverage-v8-ins…
AriPerkkio Jan 15, 2025
0edfd15
fix: check all `browser.instances` browsers
AriPerkkio Jan 15, 2025
5c289e9
docs: revert debug info removal
AriPerkkio Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/vitest/src/node/config/resolveConfig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ export function resolveConfig(
}

// Browser-mode "Playwright + Chromium" only features:
if (browser.enabled && !(browser.provider === 'playwright' && browser.name === 'chromium')) {
if (browser.enabled && !(browser.provider === 'playwright' && (browser.name === 'chromium' || browser.instances?.find(i => i?.browser === 'chromium')))) {
const browserConfig = { browser: { provider: browser.provider, name: browser.name } }

if (resolved.coverage.enabled && resolved.coverage.provider === 'v8') {
Expand Down
Loading