fix(browser): scale iframe for non ui case #6512

hi-ogawa · 2024-09-15T09:32:28Z

Description

closes Browser viewport does not match iframe viewport when the UI is disabled #6485
closes bug: fixed positioning cannot be used in vitest browser headless mode #7742

The test case I added is failing on webdriverio regardless of with or without UI. I couldn't figure out webdriverio, so this PR only fixes playwright where it has inconsistency with or without UI.

todo

playwirhgt
- works except macos chromium
preview provider
- works
webdriverio provider (keep as is for now)
- scaling breaks interaction API. It's also reproducible with UI (it might be same as Amazing new locators in 2.1 beta don't seem to work with the interactivity API #6449). This should be fixed first separately.
- this could be an upstream issue [🐛 Bug]: UI event doesn't work properly inside iframe scaled via css transform webdriverio/webdriverio#13724

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
Ideally, include a test that fails without this PR but passes with it.
Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

Run the tests with pnpm test:ci.

Documentation

If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

sheremet-va

This doesn't fix it when you call page.viewport

We already experimented with this before. Now we just need to keep the same iframe scaling that we have in ui

hi-ogawa · 2024-09-16T01:11:00Z

This doesn't fix it when you call page.viewport

Ah, I didn't think about that. I've read #6257 and scaling seems more involved but I'll see what I can do.

netlify · 2024-09-18T00:53:33Z

✅ Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`a82ae78`
🔍 Latest deploy log	https://app.netlify.com/sites/vitest-dev/deploys/67107c43b2c76d000827d8c0
😎 Deploy Preview	https://deploy-preview-6512--vitest-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

This reverts commit 8fe8f35.

This reverts commit 402b571.

hi-ogawa

Only Mac chromium playwright is timing out with specs/runner.test.ts https://github.com/vitest-dev/vitest/actions/runs/10915841527/job/30296283296?pr=6512#step:9:24

I cannot reproduce it locally on my Linux chromium headless, so it's hard to diagnose what's wrong. I would appreciate if someone can check it on Mac machine locally.

test/browser/test/userEvent.test.ts

packages/browser/src/client/orchestrator.ts

nstepien · 2025-01-21T18:28:35Z

Is this still blocked?

hi-ogawa · 2025-02-15T05:32:54Z

I updated a branch but Mac seems still flaky. The last run passed but 2nd last run seemed stuck in timeout.

hi-ogawa · 2025-04-03T05:00:09Z

Hopefully flakiness is finally gone...

sheremet-va · 2025-04-03T12:46:32Z

packages/browser/src/client/tester/utils.ts

    throw new Error(`Cannot find Tester element. This is a bug in Vitest. Please, open a new issue with reproduction.`)
  }
  const scaleAttribute = testerUi.getAttribute('data-scale')
+  if (scaleAttribute === null) {


We should always add a data-scale attribute and throw an error if it's incorrect. The isNaN check after that checks exactly that scenario

v3.1.2 🐞 Bug Fixes Add global chai variable in vitest/globals (fix: #7474) - by @Jay-Karia in vitest-dev/vitest#7771 and vitest-dev/vitest#7474 (d9297) Prevent modifying test.exclude when same object passed in coverage.exclude - by @AriPerkkio in vitest-dev/vitest#7774 (c3751) Fix already hoisted mock - by @hi-ogawa in vitest-dev/vitest#7815 (773b1) Fix test.scoped inheritance - by @hi-ogawa in vitest-dev/vitest#7814 (db6c3) Remove pointer-events-none after resizing the left panel - by @alexprudhomme in vitest-dev/vitest#7811 (a7e77) Default to run mode when stdin is not a TTY - by @kentonv, @hi-ogawa and @sheremet-va in vitest-dev/vitest#7673 (6358f) Use happy-dom/jsdom types for envionmentOptions - by @hi-ogawa in vitest-dev/vitest#7795 (67430) browser: Fix transform error before browser server initialization - by @hi-ogawa in vitest-dev/vitest#7783 (5f762) Fix mocking from outside of root - by @hi-ogawa in vitest-dev/vitest#7789 (03f55) Scale iframe for non ui case - by @hi-ogawa in vitest-dev/vitest#6512 (c3374) coverage: await profiler calls - by @AriPerkkio in vitest-dev/vitest#7763 (795a6) Expose profiling timers - by @AriPerkkio in vitest-dev/vitest#7820 (5652b) deps: Update all non-major dependencies - in vitest-dev/vitest#7765 (7c3df) Update all non-major dependencies - in vitest-dev/vitest#7831 (15701) runner: Correctly call test hooks and teardown functions - by @sheremet-va in vitest-dev/vitest#7775 (3c00c) Show stacktrace on test timeout error - by @hi-ogawa in vitest-dev/vitest#7799 (df33b) ui: Load panel sizes from storage on initial load - by @userquin in vitest-dev/vitest#7265 (6555d) vite-node: Named export should overwrite export all - by @hi-ogawa in vitest-dev/vitest#7846 (5ba0d) Add ERR_MODULE_NOT_FOUND code error if module cannot be loaded - by @sheremet-va in vitest-dev/vitest#7776 (f9eac) 🏎 Performance browser: Improve browser parallelisation - by @sheremet-va in vitest-dev/vitest#7665 (816a5)

hi-ogawa added 3 commits September 15, 2024 18:28

fix(browser): fix viewport for non ui case

c13849c

test: tweak

8df9e9c

test: playwright only

2cdab66

hi-ogawa changed the title ~~fix(browser): fix viewport for non ui case~~ fix(browser): fix viewport for non ui case on playwright provider Sep 15, 2024

hi-ogawa marked this pull request as ready for review September 15, 2024 10:07

sheremet-va requested changes Sep 15, 2024

View reviewed changes

hi-ogawa added 3 commits September 17, 2024 14:18

Merge branch 'main' into fix-browser-non-ui-viewport

e2d9d09

fix: scale iframe wrapper

ad7f47e

fix: set data-scale

fd69f0c

hi-ogawa marked this pull request as draft September 17, 2024 06:56

Merge branch 'main' into fix-browser-non-ui-viewport

43459ea

hi-ogawa added 3 commits September 18, 2024 11:12

fix: scale userEvent

ecac5ad

wip: tweak

8fe8f35

wip: how about ubuntu

402b571

hi-ogawa changed the title ~~fix(browser): fix viewport for non ui case on playwright provider~~ fix(browser): scale iframe for non ui case Sep 18, 2024

hi-ogawa added 5 commits September 18, 2024 12:14

Revert "wip: tweak"

3196a22

This reverts commit 8fe8f35.

Revert "wip: how about ubuntu"

8d49953

This reverts commit 402b571.

chore: revert this too

2c36ca9

test: non exact click position

5f76302

wip: give up webdriverio

3db24eb

hi-ogawa commented Sep 18, 2024

View reviewed changes

test/browser/test/userEvent.test.ts Show resolved Hide resolved

packages/browser/src/client/orchestrator.ts Outdated Show resolved Hide resolved

hi-ogawa added 7 commits September 18, 2024 15:22

Merge branch 'main' into fix-browser-non-ui-viewport

24bbb16

Merge branch 'main' into fix-browser-non-ui-viewport

d3fef7c

fix: scale all providers + relax tests

900f33a

Merge branch 'main' into fix-browser-non-ui-viewport

75531f6

fix: leave webdriverio out

e983ea3

chore: comment

e68478d

test: tweak

06c9297

hi-ogawa added 2 commits October 17, 2024 11:53

Merge branch 'main' into fix-browser-non-ui-viewport

a82ae78

Merge branch 'main' into fix-browser-non-ui-viewport

e02cc1d

hi-ogawa mentioned this pull request Feb 11, 2025

[browser mode] headless browser test fails where test with ui doesn't #7462

Closed

6 tasks

hi-ogawa added 2 commits February 14, 2025 16:52

Merge branch 'main' into fix-browser-non-ui-viewport

9b18f3f

chore: cleanup

453bb8e

Merge branch 'main' into fix-browser-non-ui-viewport

fc940e3

hi-ogawa mentioned this pull request Apr 3, 2025

bug: fixed positioning cannot be used in vitest browser headless mode #7742

Closed

6 tasks

hi-ogawa added 4 commits April 3, 2025 11:41

Merge branch 'main' into fix-browser-non-ui-viewport

09f14ee

chore: lint

f63502b

test: tweak

3c0e0c7

chore: cleanup

6c646fa

hi-ogawa marked this pull request as ready for review April 3, 2025 04:50

sheremet-va requested changes Apr 3, 2025

View reviewed changes

refactor: move data-scale

e89b710

sheremet-va approved these changes Apr 16, 2025

View reviewed changes

sheremet-va merged commit c337480 into vitest-dev:main Apr 17, 2025
13 of 14 checks passed

hi-ogawa deleted the fix-browser-non-ui-viewport branch April 17, 2025 23:43

sheremet-va mentioned this pull request Apr 24, 2025

Inexplicable and flaky userEvent action timeouts #7871

Open

6 tasks

github-actions bot mentioned this pull request Apr 28, 2025

fix(deps): update all non-major dependencies AmadeusITGroup/AgnosUI#1168

Merged

1 task

This was referenced May 15, 2025

fix(deps): update all non-major dependencies daku10/github-merge-guardian#120

Merged

fix(deps): update all non-major dependencies adrianmjim/hono-api-example#17

Open

unional mentioned this pull request Jun 1, 2025

All snapshots suddenly mismatched repobuddy/visual-testing#300

Closed

renovate bot mentioned this pull request May 31, 2025

Update all patch dependencies sarvex/qusyd.com#535

Merged

1 task

renovate bot mentioned this pull request Jun 17, 2025

fix(deps): update all dependencies un-ts/cf-cleaner#64

Open

1 task

renovate bot mentioned this pull request Jun 29, 2025

Update devDependencies NullVoxPopuli/eslint-configs#687

Open

1 task

sheremet-va mentioned this pull request Oct 16, 2025

When browser.viewport is set and with the webdriver backend, sometimes parts of the app are unreachable #8723

Open

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(browser): scale iframe for non ui case #6512

fix(browser): scale iframe for non ui case #6512

Uh oh!

hi-ogawa commented Sep 15, 2024 •

edited

Loading

Uh oh!

sheremet-va left a comment

Uh oh!

hi-ogawa commented Sep 16, 2024

Uh oh!

netlify bot commented Sep 18, 2024 •

edited

Loading

Uh oh!

hi-ogawa left a comment

Uh oh!

Uh oh!

Uh oh!

nstepien commented Jan 21, 2025

Uh oh!

hi-ogawa commented Feb 15, 2025

Uh oh!

hi-ogawa commented Apr 3, 2025

Uh oh!

sheremet-va Apr 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

fix(browser): scale iframe for non ui case #6512

fix(browser): scale iframe for non ui case #6512

Uh oh!

Conversation

hi-ogawa commented Sep 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

Tests

Documentation

Changesets

Uh oh!

sheremet-va left a comment

Choose a reason for hiding this comment

Uh oh!

hi-ogawa commented Sep 16, 2024

Uh oh!

netlify bot commented Sep 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for vitest-dev ready!

Uh oh!

hi-ogawa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nstepien commented Jan 21, 2025

Uh oh!

hi-ogawa commented Feb 15, 2025

Uh oh!

hi-ogawa commented Apr 3, 2025

Uh oh!

sheremet-va Apr 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hi-ogawa commented Sep 15, 2024 •

edited

Loading

netlify bot commented Sep 18, 2024 •

edited

Loading