Skip to content

Conversation

@aqandrew
Copy link
Contributor

A missing async threw an error in the Learn With Jason livestream on Vitest browser mode with Vladimir Sheremet.

Browser mode looks super cool!

Description

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

A missing `async` threw an error in the Learn With Jason livestream on Vitest browser mode with Vladimir Sheremet.

Browser mode looks super cool!
@netlify
Copy link

netlify bot commented Sep 12, 2024

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a8c26ab
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/66e31fbfd838130008d963b2
😎 Deploy Preview https://deploy-preview-6484--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@AriPerkkio AriPerkkio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@AriPerkkio AriPerkkio merged commit 16aa76c into vitest-dev:main Sep 12, 2024
@aqandrew aqandrew deleted the patch-1 branch September 12, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants