Skip to content

Conversation

@BreakBB
Copy link
Contributor

@BreakBB BreakBB commented Sep 28, 2023

Fixes #4194

Description

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link

netlify bot commented Sep 28, 2023

Deploy Preview for fastidious-cascaron-4ded94 ready!

Name Link
🔨 Latest commit 44e9142
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/65156e3ab0a56b0008720bfd
😎 Deploy Preview https://deploy-preview-4195--fastidious-cascaron-4ded94.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@BreakBB
Copy link
Contributor Author

BreakBB commented Sep 28, 2023

Is there anything I can do about the broken pipelines? it seems at least some of these are broken on main as well 🤔

@sheremet-va
Copy link
Member

Is there anything I can do about the broken pipelines? it seems at least some of these are broken on main as well 🤔

Yeah, it's just unstable for now.

@BreakBB
Copy link
Contributor Author

BreakBB commented Sep 29, 2023

Pardon me @sheremet-va : Can I do something more for this PR or not?

@sheremet-va sheremet-va merged commit ab5dd10 into vitest-dev:main Sep 29, 2023
@BreakBB BreakBB deleted the fix-cve-2023-43646 branch September 29, 2023 09:13
LorenzoBloedow pushed a commit to LorenzoBloedow/vitest that referenced this pull request Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@vitest/expect vulnerable to CVE-2023-43646

2 participants